search

microsoft / PowerBI-visuals-tools

Contains tools for building/packaging Power BI visuals
https://www.powerbi.com
MIT License
336 stars 152 forks source link

Added guid flag for custom builds #481

Closed YuliaStrun closed 1 year ago

YuliaStrun commented 1 year ago

Description

Implemented flag for pbiviz package command to specify custom guid without changing pbiviz json. I also implemented one test to make sure that the value is changing. However, there might be a problem if the developer enters a numeric value since this value is used as the name of the variable in visualPlugin.ts. What do we want to do in this case? Maybe to use some default value instead or just to throw an error?

Why I did this

Right now running pbiviz package command builds the visual using guid value from pbiviz.json file. It causes problems with testing packages.

Appreciate any feedback😊

YuliaStrun commented 1 year ago

@microsoft-github-policy-service agree

AleksSavelev commented 1 year ago

I think we should implement this feature request instead of this flag

YuliaStrun commented 1 year ago

According to issues decided to solve this issue with another approach.

495