search

microsoft / PowerPlatformConnectors

This is a repository for Microsoft Power Automate, Power Apps, and Azure Logic Apps connectors
https://aka.ms/connectors
MIT License
975 stars 1.26k forks source link

[BUG] Power Automate Editor Import OpenAPI 3.0 - allOf not changed #2067

Open troystaylor opened 2 years ago

troystaylor commented 2 years ago

Type of Connector

Custom Connector

Name of Connector

GitHub Gists

Describe the bug

I was able to successfully import the connector definition (after removing non-Gists-related definitions) from: https://raw.githubusercontent.com/github/rest-api-description/main/descriptions/api.github.com/api.github.com.json In the Swagger Editor, I can see that the definition has been downgraded to 2.0. However, the allOf keyword has still been included. So, I have two questions:

  1. Does the Editor saving without an error mean that the custom connector can be used with the allOf parameters?
  2. The paconn CLI validate command completes with warnings, but should these be fixed before submission as an Independent Publisher connector? (I may fix and submit anyways, as it is only two warnings)

image

Is this a security bug?

No, this is not a security bug

What is the severity of this bug?

Severity 3 - Minor issue

To Reproduce

Import OpenAPI definition that includes allOf keyword (I'm guessing this is similar for oneOf, anyOf, and not as well)

Expected behavior

Editor downgrade removes the need for allOf keyword

Environment summary

Install Method (e.g. pip, interactive script, apt-get, Docker, MSI, edge build) CLI version (paconn --version) OS version Shell Type (e.g. bash, cmd.exe, Bash on Windows)

Additional context

None

aSeriousDeveloper commented 1 year ago

Hi, is there a fix, or known workaround for this? I've had this same issue pop up when importing a 3.0 spec generated by swagger-php.