Closed danmcpherson closed 1 week ago
Confirming that existing flows will not break, I’m aware and managed these changes.
I’ve updated the spelling/typos. Daniel
From: vmanoharas @.> Date: Friday, 20 September 2024 at 11:22 To: microsoft/PowerPlatformConnectors @.> Cc: Daniel McPherson @.>, Mention @.> Subject: Re: [microsoft/PowerPlatformConnectors] Sync changes from release-package fork V1.1.1 (PR #3656)
@vmanoharas commented on this pull request.
Hello @danmcphersonhttps://github.com/danmcpherson,
Kindly address review comments. Additionally, please see the swagger validation errors below and confirm that the existing flows would break or not?
In certified-connectors/Tendocs Documents/apiDefinition.swagger.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/3656#discussion_r1768243288:
- "schema": {
"$ref": "#/definitions/TemplateResponse"
}
},
"403": {
"description": "The request is not authorized to make the template request"
},
"404": {
"description": "Service has not been found, please contact @.***"
},
"500": {
"description": "Something has gone wrong, please contact @.***"
}
},
"summary": "Create a new document from a template and JSON",
"description": "Create a new Office document by merging an office template with JSON Obeject."
Please correct the typo "Obeject"
In certified-connectors/Tendocs Documents/apiDefinition.swagger.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/3656#discussion_r1768245959:
- "type": "string",
"example": "Summary",
"x-ms-summary": "Type",
"description": "The type of summary provided."
},
"content": {
"type": "string",
"example": "Summary of the document provided.",
"x-ms-summary": "Summary",
"description": "Summary of the document."
},
"targetWords": {
"type": "number",
"example": 300,
"x-ms-summary": "Target",
"description": "The targetted length in words."
Please correct the typo "targetted"
In certified-connectors/Tendocs Documents/apiDefinition.swagger.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/3656#discussion_r1768252426:
- "example": {
"introduction": "This document describes a set of new health and safety protocols which makes it critical all staff have reviewed."
}
},
"logoUrl": {
"type": "string",
"description": "Full URL to a logo that is displayed in the top left of the document.",
"x-ms-visibility": "advanced",
"x-ms-summary": "Document Logo",
"example": {
"logoUrl": "https://app.tendocs.com/images/doc.png"
}
},
"email": {
"type": "string",
"description": "Email address of the document recipeint.",
Please correct the typo
In certified-connectors/Tendocs Documents/apiDefinition.swagger.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/3656#discussion_r1768255602:
- "example": {
"checkboxText": "By checking this box you agree that you have read the updated Health and Safety protocols."
}
},
"expiry": {
"type": "string",
"description": "The date after which the document is no longer valid and cannot be accessed.",
"x-ms-visibility": "important",
"x-ms-summary": "Expiry Date",
"example": {
"expiry": "2024-06-01T09:00:00Z"
}
},
"isSignatureRequired": {
"type": "boolean",
"description": "Determines if the recipents name and an empty text box where they need to enter their name is included on the document page.",
Please correct the recipents
In certified-connectors/Tendocs Documents/apiDefinition.swagger.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/3656#discussion_r1768258558:
- "example": {
"expiry": "2024-06-01T09:00:00Z"
}
},
"isSignatureRequired": {
"type": "boolean",
"description": "Determines if the recipents name and an empty text box where they need to enter their name is included on the document page.",
"x-ms-visibility": "important",
"x-ms-summary": "Signature Required",
"example": {
"isSignatureRequired": true
}
},
"organisationTitle": {
"type": "string",
"description": "The title of the company, department or organisation that is repsonsible for sending the document.",
Please correct the type "repsonsible"
In certified-connectors/Tendocs Documents/apiDefinition.swagger.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/3656#discussion_r1768260789:
- }
},
"isSignatureRequired": {
"type": "boolean",
"description": "Determines if the recipents name and an empty text box where they need to enter their name is included on the document page.",
"x-ms-visibility": "important",
"x-ms-summary": "Signature Required",
"example": {
"isSignatureRequired": true
}
},
"organisationTitle": {
"type": "string",
"description": "The title of the company, department or organisation that is repsonsible for sending the document.",
"x-ms-visibility": "important",
"x-ms-summary": "Organsiation Title",
Please correct the typo "Organsiation"
In certified-connectors/Tendocs Documents/apiDefinition.swagger.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/3656#discussion_r1768262191:
- "example": {
"isSignatureRequired": true
}
},
"organisationTitle": {
"type": "string",
"description": "The title of the company, department or organisation that is repsonsible for sending the document.",
"x-ms-visibility": "important",
"x-ms-summary": "Organsiation Title",
"example": {
"organisation": "Human Resources"
}
},
"organisationWebsite": {
"type": "string",
"description": "Link to a webiste. This could be internal, or external to the organisation and provide more details on the document or process.",
Please correct the type "webiste"
In certified-connectors/Tendocs Documents/apiDefinition.swagger.jsonhttps://github.com/microsoft/PowerPlatformConnectors/pull/3656#discussion_r1768263916:
- }
},
"organisationContactName": {
"type": "string",
"description": "Name of the owner who is responsible for the document or process.",
"x-ms-visibility": "important",
"x-ms-summary": "Organisation Owner",
"example": {
"organisationContactName": "Pauline Jones"
}
},
"organisationContactTitle": {
"type": "string",
"description": "Job title of the owner who is responsible for the document or process.",
"x-ms-visibility": "advanced",
"x-ms-summary": "Oragnisation Owner Title",
Please correct the typo "Oragnisation"
— Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerPlatformConnectors/pull/3656#pullrequestreview-2317675642, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AELSPBI2MH7OXLIMG4BCLXLZXPSLTAVCNFSM6AAAAABONWVPNSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMJXGY3TKNRUGI. You are receiving this because you were mentioned.Message ID: @.***>
Fixed and committed.
When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.
apiDefinition.swagger.json
, by runningpaconn validate
command.apiProperties.json
has a valid brand color and doesn't use an invalid brand color,#007ee5
or#ffffff
. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process: