search

microsoft / PowerShellForGitHub

Microsoft PowerShell wrapper for GitHub API
Other
588 stars 185 forks source link

Invalid asset name if Set-GitHubReleaseAsset used with non-ascii file path #327

Closed sergey-s-betke closed 3 years ago

sergey-s-betke commented 3 years ago

Issue Details

After Set-GitHubReleaseAsset call with with non-ascii file path created asset with invalid name (without all non-ascii chars)

Steps to reproduce the issue

$release | New-GitHubReleaseAsset `
              -Path ( 'test документ.odt' ) `
              -Label ( 'test документ.odt' ) `
              -ContentType 'application/vnd.oasis.opendocument.text' `
              -Verbose;

PowerShell Version

Name                           Value
----                           -----
PSVersion                      5.1.15063.674
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.15063.674
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Module Version

Running: 0.16.0
Installed: 0.16.0
HowardWolosky commented 3 years ago

This isn't a PowerShellForGitHub bug. This is unfortunately a GitHub issue. The exact same thing will happen if you upload the file directly via the GitHub webpage release editor.

This module is sending the appropriate information. GitHub is just handling the information incorrectly on their end.

I recommend that you submit feedback directly to GitHub and let us know what they say: https://support.github.com/contact/feedback