microsoft / PowerShellForGitHub

Microsoft PowerShell wrapper for GitHub API
Other
588 stars 185 forks source link

Fix coalesced Team permission property #361

Closed HowardWolosky closed 1 year ago

HowardWolosky commented 2 years ago

Description

When retrieving the permissions granted to a team for a repository, the API returns an array of booleans indicating what individual permissions the team currently has.

name permissions granted
pull pull
triage pull, triage
push pull, triage, push
maintain pull, triage, push, maintain
admin pull, triage, push, maintain, admin

As you can see, each permissions builds on top of the previous permission. When adding extra properties to this returned object via Add-GitHubRepositoryTeamPermissionAdditionalProperties, we also add a new permission property that attempts to represent the collection of permissions with their current top-permission level.

The logic however incorrectly favored push over maintain and thus would always said that a Team had push permission when in fact it may have actually had maintain permission.

This simple change corrects that ordering mistake.

Issues Fixed

Fixes #360

References

Check team permissions for a repository

Checklist