Closed StanleyGoldman closed 10 months ago
Thanks @StanleyGoldman -- I have this queued for review this week.
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 14 days of this comment.
This pull request has been automatically closed due to a lack of activity from the author. We understand. Life happens and other things likely came up. We would still love to see your contribution get merged in. Now that it has been closed, a different community member may wish to pick up where you left off. If so, they should speak up by commenting below. If you're still interested in completing this yourself, just respond back and let us know.
Heya, I'd still love to get this change in.
Heya, I'd still love to get this change in.
That's great news. I'm re-opening the PR. Your next step is to address the PR feedback and to resolve the merge conflicts.
@HowardWolosky ready when you are.
Changes made.
As GitHub staff I was a bit reluctant to run integration tests that used GitHub as a testbed. I was hoping there might be some GitHub Action (my team, shameless plug) that kicked in when you started to look at my PR that would catch my mistakes. Also laziness. Alas, you caught me. Apologies 🙏.
I was hoping there might be some GitHub Action (my team, shameless plug) that kicked in when you started to look at my PR that would catch my mistakes.
I do run the CI pipeline before merging any changes, but that intentionally requires a manual comment by me to get started (which the ADO pipeline bot monitors).
/azp run PowerShellForGitHub-CI
/azp run PowerShellForGitHub-CI
/azp run PowerShellForGitHub-CI
/azp run PowerShellForGitHub-CI
/azp run PowerShellForGitHub-CI
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 14 days of this comment.
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 14 days of this comment.
This pull request has been automatically closed due to a lack of activity from the author. We understand. Life happens and other things likely came up. We would still love to see your contribution get merged in. Now that it has been closed, a different community member may wish to pick up where you left off. If so, they should speak up by commenting below. If you're still interested in completing this yourself, just respond back and let us know.
Description
As mentioned in #335, this pull request adds functionality to upload binary content with Set-GitHubContent
336 got closed to due inactivity. Apologies. I'm still very interested in getting this code merged.
Issues Fixed
Fixes #335
References
Checklist