microsoft / PowerShellForGitHub

Microsoft PowerShell wrapper for GitHub API
Other
588 stars 185 forks source link

Pester v5 #366

Closed tigerfansga closed 1 year ago

tigerfansga commented 2 years ago

Description

Update pester test for Pester v5 support

Issues Fixed

References

Checklist

ghost commented 2 years ago

CLA assistant check
All CLA requirements met.

HowardWolosky commented 2 years ago

Thanks @tigerfansga -- I have this queued for review this week.

HowardWolosky commented 1 year ago

Thanks @tigerfansga -- I have this queued for review this week.

Got a bit delayed -- I have started reviewing this, but it's going to take me a couple more days though to finish getting through it. Thanks for your contribution (and your patience)!

tigerfansga commented 1 year ago

Thanks @tigerfansga -- I have this queued for review this week.

Got a bit delayed -- I have started reviewing this, but it's going to take me a couple more days though to finish getting through it. Thanks for your contribution (and your patience)!

No problem. It's a lot to go through.

HowardWolosky commented 1 year ago

/azp run PowerShellForGitHub-CI

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 1 pipeline(s).
HowardWolosky commented 1 year ago

/azp run PowerShellForGitHub-CI

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 1 pipeline(s).
HowardWolosky commented 1 year ago

/azp run PowerShellForGitHub-CI

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 1 pipeline(s).
HowardWolosky commented 1 year ago

@tigerfansga - You'll need to sign the CLA via the bot using the command @microsoft-github-policy-service agree.

Still looking through the test failures to see if there's anything there related to your changes...

tigerfansga commented 1 year ago

@tigerfansga - You'll need to sign the CLA via the bot using the command @microsoft-github-policy-service agree.

Still looking through the test failures to see if there's anything there related to your changes...

That is strange on the CLA because I had accepted it. I can get that done later today. I'm not sure I'll be able to review any requested changes till after the New Year.

tigerfansga commented 1 year ago

@microsoft-github-policy-service agree

HowardWolosky commented 1 year ago

/azp run PowerShellForGitHub-CI

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 1 pipeline(s).
HowardWolosky commented 1 year ago

/azp run PowerShellForGitHub-CI

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 1 pipeline(s).
HowardWolosky commented 1 year ago

/azp run PowerShellForGitHub-CI

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 1 pipeline(s).
HowardWolosky commented 1 year ago

I cleaned up the remaining work in here and got it merged in. Thanks so much to @tigerfansga for taking this work on and moving the project forward. It's HUGE that we can now run individual tests directly within VS Code now that we're on Pester 5.
Thanks so much for the contribution!