Closed tigerfansga closed 1 year ago
Thanks @tigerfansga -- I have this queued for review this week.
Thanks @tigerfansga -- I have this queued for review this week.
Got a bit delayed -- I have started reviewing this, but it's going to take me a couple more days though to finish getting through it. Thanks for your contribution (and your patience)!
Thanks @tigerfansga -- I have this queued for review this week.
Got a bit delayed -- I have started reviewing this, but it's going to take me a couple more days though to finish getting through it. Thanks for your contribution (and your patience)!
No problem. It's a lot to go through.
/azp run PowerShellForGitHub-CI
/azp run PowerShellForGitHub-CI
/azp run PowerShellForGitHub-CI
@tigerfansga - You'll need to sign the CLA via the bot using the command @microsoft-github-policy-service agree
.
Still looking through the test failures to see if there's anything there related to your changes...
@tigerfansga - You'll need to sign the CLA via the bot using the command
@microsoft-github-policy-service agree
.Still looking through the test failures to see if there's anything there related to your changes...
That is strange on the CLA because I had accepted it. I can get that done later today. I'm not sure I'll be able to review any requested changes till after the New Year.
@microsoft-github-policy-service agree
/azp run PowerShellForGitHub-CI
/azp run PowerShellForGitHub-CI
/azp run PowerShellForGitHub-CI
I cleaned up the remaining work in here and got it merged in. Thanks so much to @tigerfansga for taking this work on and moving the project forward. It's HUGE that we can now run individual tests directly within VS Code now that we're on Pester 5.
Thanks so much for the contribution!
Description
Update pester test for Pester v5 support
Issues Fixed
References
Checklist
Comment-based help added/updated, including examples.Formatters were created for any new types being added.New/changed code continues to support the pipeline.Changes to the manifest file follow the manifest guidance.Relevant usage examples have been added/updated in USAGE.md.