Set-GitHubRepository: Add Support for 'Secret Scanning' Option

X-Guardian commented 1 year ago

Description

This PR adds the SecretScanning parameter to the Set-GitHubRepository function:

Note: The parameter was implemented using the Enabled, Disabled parameter validate set rather than a switch to mirror the pattern used by the GitHub API.

Issues Fixed

Fixes #390

References

https://docs.github.com/en/rest/repos/repos#update-a-repository

Checklist

[x] You actually ran the code that you just wrote, especially if you did just "one last quick change".
[x] Comment-based help added/updated, including examples.
[x] Static analysis is reporting back clean.
[x] New/changed code adheres to our coding guidelines.
[ ] Formatters were created for any new types being added.
[x] New/changed code continues to support the pipeline.
[ ] Changes to the manifest file follow the manifest guidance.
[x] Unit tests were added/updated and are all passing. See testing guidelines. This includes making sure that all pipeline input variations have been covered.
[ ] Relevant usage examples have been added/updated in USAGE.md.
[ ] If desired, ensure your name is added to our Contributors list

X-Guardian commented 1 year ago

@HowardWolosky, this PR is ready for review.

HowardWolosky commented 1 year ago

/azp run PowerShellForGitHub-CI

azure-pipelines[bot] commented 1 year ago

Azure Pipelines successfully started running 1 pipeline(s).

X-Guardian commented 1 year ago

@HowardWolosky, any timescale on when you will be able to re-review this PR?

HowardWolosky commented 1 year ago

/azp run PowerShellForGitHub-CI

azure-pipelines[bot] commented 1 year ago

Azure Pipelines successfully started running 1 pipeline(s).

HowardWolosky commented 1 year ago

/azp run PowerShellForGitHub-CI

It looks like there is a consistent failure with this change on two New-GitHubRepository tests. The failures are occurring when validating the has_wiki value. I'm going to kick off a run against master to see if the failure is happening without your changes as well.

X-Guardian commented 1 year ago

/azp run PowerShellForGitHub-CI

It looks like there is a consistent failure with this change on two New-GitHubRepository tests. The failures are occurring when validating the has_wiki value. I'm going to kick off a run against master to see if the failure is happening without your changes as well.

It looks like Wikis aren't supported on private repos on the free tier anymore. I'll raise a PR to update the tests to not check for the has_wiki value in these circumstances.

Issue raised: #403

HowardWolosky commented 1 year ago

/azp run PowerShellForGitHub-CI

azure-pipelines[bot] commented 1 year ago

Azure Pipelines successfully started running 1 pipeline(s).

microsoft / PowerShellForGitHub