microsoft / PowerToys

Windows system utilities to maximize productivity
MIT License
110.86k stars 6.53k forks source link

[PowerToys Run] Add favicons from website url #10114

Open luximus-hunter opened 3 years ago

luximus-hunter commented 3 years ago

📝 Provide a description of the new feature

What is the expected behavior of the proposed feature? What is the scenario this would be used?

When searching for a web url in PowerToys Run, it would be better to display the website icon than the browser icon. That way people can see if they make a typo and possibly save them from a dangerous website.


If you'd like to see this feature implemented, add a 👍 reaction to this post.

crutkas commented 3 years ago

a favicon won't prevent the dangerous website scenario but not a bad idea to have this load async

htcfreek commented 3 years ago

But then we need a new way to show the used browser's icon/name. (We use the default browser.)

luximus-hunter commented 3 years ago

An optin is to not display the borsers icon, but to have small text underneath the url, something like Browse with [default browser]

crutkas commented 3 years ago

Those are different requests than what the root request is here.

htcfreek commented 3 years ago

Those are different requests than what the root request is here.

@crutkas No.

The root request was to show the favicon in front of the result to prevent opening dangerous websites.

I hint that we use the result icon to show which browser will be used. (What browser is set as default browser.) And @luximus-hunter suggest that we could use the subtitle to show the browser's name, so that we can use the result icon for the favicon.

luximus-hunter commented 3 years ago

Yes, apologies for my bad explaining

crutkas commented 3 years ago

Showing a fav icon doesn't do what they are asking at the end of the day. Doesn't prevent mistypes as those sites could also have the same favicon too

I think it is decent eye candy but will induce a latency for loading the icon / visual pop unless it is already cached somehow as PT Run would have fetch it

Then what about redirects like aka links? What is the behavior

intercepted16 commented 3 months ago

I believe that latency would only be introduced on the first website visit through Powertoys Run. Simply cache it after the first request and forget about it. This could be run asynchronously and display a generic world wide web icon or the current default browser icon if a favicon could not be found. You could pre-cache common websites like www.google.com as well.

And redirect links could simply be followed till you reach the end destination, or you could just ignore links with that redirect elsewhere. Or you could have a common list of aka links, like youtu.be and display their favicons.