search

microsoft / PowerToys

Windows system utilities to maximize productivity
MIT License
111.64k stars 6.57k forks source link

Build fail in cp949 encoding #10873

Closed hankyulhyun closed 1 year ago

hankyulhyun commented 3 years ago

Microsoft PowerToys version

master (150ffe6)

Utility with translation issue

General

🌐 Language affected

Korean

❌ Actual phrase(s)

Hello, I'm HanKyul in South Korea. I'm very interested in this project so I want to contribute. First, I tried to build in my windows 10 machine but it failed.

When I turn off "Treat Warning As Errors" in all cpp project setting, It works. However, it is not good way I think.

Do you have any good idea about it? or there is sth what I'm missing..? (cp949 in visual studio is default in Windows 10 Korean version)

Thank you very much =)

image

✔️ Expected phrase(s)

Build success

ℹ Why is the current translation wrong

Actually not translation issue.

crutkas commented 3 years ago

@hankyulhyun can you actually paste in the output?

hankyulhyun commented 3 years ago

@crutkas Sure =) This is second time build without clean

1>------ Build started: Project: spdlog, Configuration: Debug x64 ------ 2>------ Build started: Project: Wox.Infrastructure, Configuration: Debug x64 ------ 3>------ Build started: Project: PreviewHandlerCommon, Configuration: Debug x64 ------ 4>------ Build started: Project: KeyboardManagerUI, Configuration: Debug x64 ------ 3>PreviewHandlerCommon -> C:\Users\hyunh\Documents_Project\PowerToys\x64\Debug\modules\FileExplorerPreview\PreviewHandlerCommon.dll 5>------ Build started: Project: ColorPickerUI, Configuration: Debug x64 ------ 4>"C:\Users\hyunh\Documents_Project\PowerToys\src\modules\keyboardmanager\dll\Resources.resx"에서 55 리소스를 읽습니다. 5>ColorPickerUI -> C:\Users\hyunh\Documents_Project\PowerToys\x64\Debug\modules\ColorPicker\ColorPickerUI.dll 6>------ Build started: Project: MarkdownPreviewHandler, Configuration: Debug x64 ------ 2>Wox.Infrastructure -> C:\Users\hyunh\Documents_Project\PowerToys\x64\Debug\modules\launcher\WoxInfrastructure\Wox.Infrastructure.dll 7>------ Build started: Project: Microsoft.Plugin.Folder, Configuration: Debug x64 ------ 6>MarkdownPreviewHandler -> C:\Users\hyunh\Documents_Project\PowerToys\x64\Debug\modules\FileExplorerPreview\MarkdownPreviewHandler.dll 7>Microsoft.Plugin.Folder -> C:\Users\hyunh\Documents_Project\PowerToys\x64\Debug\modules\launcher\Plugins\Microsoft.Plugin.Folder\Microsoft.Plugin.Folder.dll 8>------ Build started: Project: Microsoft.PowerToys.Run.Plugin.Calculator, Configuration: Debug x64 ------ 9>------ Build started: Project: Microsoft.Plugin.WindowWalker, Configuration: Debug x64 ------ 9>Microsoft.Plugin.WindowWalker -> C:\Users\hyunh\Documents_Project\PowerToys\x64\Debug\modules\launcher\Plugins\Microsoft.Plugin.WindowWalker\Microsoft.Plugin.WindowWalker.dll 10>------ Build started: Project: Microsoft.Plugin.Shell, Configuration: Debug x64 ------ 8>Microsoft.PowerToys.Run.Plugin.Calculator -> C:\Users\hyunh\Documents_Project\PowerToys\x64\Debug\modules\launcher\Plugins\Calculator\Microsoft.PowerToys.Run.Plugin.Calculator.dll 11>------ Build started: Project: Microsoft.Plugin.Indexer, Configuration: Debug x64 ------ 10>Microsoft.Plugin.Shell -> C:\Users\hyunh\Documents_Project\PowerToys\x64\Debug\modules\launcher\Plugins\Microsoft.Plugin.Shell\Microsoft.Plugin.Shell.dll 12>------ Build started: Project: Microsoft.Plugin.Program, Configuration: Debug x64 ------ 1>spdlog.cpp 1>stdout_sinks.cpp 1>color_sinks.cpp 1>async.cpp 1>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): error C2220: the following warning is treated as an error (compiling source file C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\src\spdlog.cpp) 1>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss (compiling source file C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\src\spdlog.cpp) 1>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): error C2220: the following warning is treated as an error (compiling source file C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\src\async.cpp) 1>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss (compiling source file C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\src\async.cpp) 1>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): error C2220: the following warning is treated as an error (compiling source file C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\src\stdout_sinks.cpp) 1>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss (compiling source file C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\src\stdout_sinks.cpp) 1>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): error C2220: the following warning is treated as an error (compiling source file C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\src\color_sinks.cpp) 1>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss (compiling source file C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\src\color_sinks.cpp) 1>cfg.cpp 1>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): error C2220: the following warning is treated as an error (compiling source file C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\src\cfg.cpp) 1>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss (compiling source file C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\src\cfg.cpp) 12>Microsoft.Plugin.Program -> C:\Users\hyunh\Documents_Project\PowerToys\x64\Debug\modules\launcher\Plugins\Microsoft.Plugin.Program\Microsoft.Plugin.Program.dll 13>------ Build started: Project: Microsoft.PowerToys.Run.Plugin.Service, Configuration: Debug x64 ------ 13>Microsoft.PowerToys.Run.Plugin.Service -> C:\Users\hyunh\Documents_Project\PowerToys\x64\Debug\modules\launcher\Plugins\Service\Microsoft.PowerToys.Run.Plugin.Service.dll 14>------ Build started: Project: Microsoft.Plugin.Uri, Configuration: Debug x64 ------ 11>Microsoft.Plugin.Indexer -> C:\Users\hyunh\Documents_Project\PowerToys\x64\Debug\modules\launcher\Plugins\Microsoft.Plugin.Indexer\Microsoft.Plugin.Indexer.dll 15>------ Build started: Project: Microsoft.PowerToys.Run.Plugin.System, Configuration: Debug x64 ------ 1>Done building project "logging.vcxproj" -- FAILED. 16>------ Build started: Project: logger, Configuration: Debug x64 ------ 14>Microsoft.Plugin.Uri -> C:\Users\hyunh\Documents_Project\PowerToys\x64\Debug\modules\launcher\Plugins\Microsoft.Plugin.Uri\Microsoft.Plugin.Uri.dll 17>------ Build started: Project: PowerLauncher, Configuration: Debug x64 ------ 15>Microsoft.PowerToys.Run.Plugin.System -> C:\Users\hyunh\Documents_Project\PowerToys\x64\Debug\modules\launcher\Plugins\System\Microsoft.PowerToys.Run.Plugin.System.dll 18>------ Build started: Project: Microsoft.PowerToys.Run.Plugin.Registry, Configuration: Debug x64 ------ 18>Microsoft.PowerToys.Run.Plugin.Registry -> C:\Users\hyunh\Documents_Project\PowerToys\x64\Debug\modules\launcher\Plugins\Microsoft.PowerToys.Run.Plugin.Registry\Microsoft.PowerToys.Run.Plugin.Registry.dll 19>------ Build started: Project: SvgPreviewHandler, Configuration: Debug x64 ------ 4>pch.cpp 17>PowerLauncher -> C:\Users\hyunh\Documents_Project\PowerToys\x64\Debug\modules\launcher\PowerLauncher.dll 20>------ Build started: Project: Microsoft.PowerToys.Settings.UI, Configuration: Debug x64 ------ 19>SvgPreviewHandler -> C:\Users\hyunh\Documents_Project\PowerToys\x64\Debug\modules\FileExplorerPreview\SvgPreviewHandler.dll 21>------ Build started: Project: SvgThumbnailProvider, Configuration: Debug x64 ------ 21>SvgThumbnailProvider -> C:\Users\hyunh\Documents_Project\PowerToys\x64\Debug\modules\FileExplorerPreview\SvgThumbnailProvider.dll 22>------ Build started: Project: Community.PowerToys.Run.Plugin.VSCodeWorkspaces, Configuration: Debug x64 ------ 22>Community.PowerToys.Run.Plugin.VSCodeWorkspaces -> C:\Users\hyunh\Documents_Project\PowerToys\x64\Debug\modules\launcher\Plugins\VSCodeWorkspaces\Community.PowerToys.Run.Plugin.VSCodeWorkspaces.dll 23>------ Build started: Project: UnitTests-PreviewHandlerCommon, Configuration: Debug x64 ------ 23>UnitTests-PreviewHandlerCommon -> C:\Users\hyunh\Documents_Project\PowerToys\src\modules\previewpane\UnitTests-PreviewHandlerCommon\bin\x64\Debug\netcoreapp3.1\UnitTests-PreviewHandlerCommon.dll 24>------ Build started: Project: Microsoft.Plugin.Program.UnitTests, Configuration: Debug x64 ------ 24>Microsoft.Plugin.Program.UnitTests -> C:\Users\hyunh\Documents_Project\PowerToys\src\modules\launcher\Plugins\Microsoft.Plugin.Program.UnitTests\bin\x64\Debug\netcoreapp3.1\Microsoft.Plugin.Program.UnitTests.dll 25>------ Build started: Project: UnitTests-SvgThumbnailProvider, Configuration: Debug x64 ------ 25>UnitTests-SvgThumbnailProvider -> C:\Users\hyunh\Documents_Project\PowerToys\src\modules\previewpane\UnitTests-SvgThumbnailProvider\bin\x64\Debug\netcoreapp3.1\UnitTests-SvgThumbnailProvider.dll 26>------ Build started: Project: Microsoft.Plugin.Uri.UnitTests, Configuration: Debug x64 ------ 16>logger.cpp 16>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): error C2220: the following warning is treated as an error 16>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss 16>Done building project "logger.vcxproj" -- FAILED. 27>------ Build started: Project: FancyZonesLib, Configuration: Debug x64 ------ 26>Microsoft.Plugin.Uri.UnitTests -> C:\Users\hyunh\Documents_Project\PowerToys\src\modules\launcher\Plugins\Microsoft.Plugin.Uri.UnitTests\bin\x64\Debug\netcoreapp3.1\Microsoft.Plugin.Uri.UnitTests.dll 28>------ Build started: Project: ShortcutGuide, Configuration: Debug x64 ------ 4>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): error C2220: the following warning is treated as an error 4>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss 27>"C:\Users\hyunh\Documents_Project\PowerToys\src\modules\fancyzones\lib\Resources.resx"에서 39 리소스를 읽습니다. 28>"C:\Users\hyunh\Documents_Project\PowerToys\src\modules\shortcut_guide\Resources.resx"에서 18 리소스를 읽습니다. 4>Done building project "KeyboardManagerUI.vcxproj" -- FAILED. 29>------ Build started: Project: KeyboardManager (modules\keyboardmanager\KeyboardManager), Configuration: Debug x64 ------ 20> Microsoft.PowerToys.Settings.UI -> C:\Users\hyunh\Documents_Project\PowerToys\x64\Debug\SettingsUI\Microsoft.PowerToys.Settings.UI.exe 28>EXEC : error : could not lock config file C:/Users/hyunh/Documents/_Project/PowerToys/.git/modules/deps/expected-lite/config: File exists 28>shortcut_guide.cpp 28>target_state.cpp 27>CallTracer.cpp 27>FancyZones.cpp 27>FancyZonesData.cpp 27>JsonHelpers.cpp 27>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): error C2220: the following warning is treated as an error (compiling source file CallTracer.cpp) 27>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss (compiling source file CallTracer.cpp) 27>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): error C2220: the following warning is treated as an error (compiling source file FancyZones.cpp) 27>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss (compiling source file FancyZones.cpp) 27>OnThreadExecutor.cpp 27>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): error C2220: the following warning is treated as an error (compiling source file FancyZonesData.cpp) 27>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss (compiling source file FancyZonesData.cpp) 27>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): error C2220: the following warning is treated as an error (compiling source file OnThreadExecutor.cpp) 27>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss (compiling source file OnThreadExecutor.cpp) 27>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): error C2220: the following warning is treated as an error (compiling source file JsonHelpers.cpp) 27>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss (compiling source file JsonHelpers.cpp) 27>ZoneSet.cpp 28>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): error C2220: the following warning is treated as an error (compiling source file target_state.cpp) 28>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss (compiling source file target_state.cpp) 28>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): error C2220: the following warning is treated as an error (compiling source file shortcut_guide.cpp) 28>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss (compiling source file shortcut_guide.cpp) 28>Done building project "shortcut_guide.vcxproj" -- FAILED. 30>------ Build started: Project: action_runner, Configuration: Debug x64 ------ 27>ZoneWindow.cpp 27>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): error C2220: the following warning is treated as an error (compiling source file ZoneSet.cpp) 27>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss (compiling source file ZoneSet.cpp) 27>ZoneWindowDrawing.cpp 31>------ Build started: Project: Microsoft.Launcher, Configuration: Debug x64 ------ 27>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): error C2220: the following warning is treated as an error (compiling source file ZoneWindow.cpp) 27>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss (compiling source file ZoneWindow.cpp) 27>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): error C2220: the following warning is treated as an error (compiling source file ZoneWindowDrawing.cpp) 27>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss (compiling source file ZoneWindowDrawing.cpp) 31>"C:\Users\hyunh\Documents_Project\PowerToys\src\modules\launcher\Microsoft.Launcher\Resources.resx"에서 2 리소스를 읽습니다. 29>"C:\Users\hyunh\Documents_Project\PowerToys\src\modules\keyboardmanager\dll\Resources.resx"에서 55 리소스를 읽습니다. 30>"C:\Users\hyunh\Documents_Project\PowerToys\src\action_runner\Resources.resx"에서 25 리소스를 읽습니다. 27>Done building project "FancyZonesLib.vcxproj" -- FAILED. 32>------ Build started: Project: fancyzones (modules\fancyzones\fancyzones), Configuration: Debug x64 ------ 31>dllmain.cpp 31>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): error C2220: the following warning is treated as an error 31>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss 29>"C:\Users\hyunh\Documents_Project\PowerToys\src\modules\keyboardmanager\dll\Resources.resx"에서 55 리소스를 읽습니다. 31>Done building project "Microsoft.Launcher.vcxproj" -- FAILED. 33>------ Build started: Project: ColorPicker (modules\colorpicker\ColorPicker), Configuration: Debug x64 ------ 33>"C:\Users\hyunh\Documents_Project\PowerToys\src\modules\colorPicker\ColorPicker\Resources.resx"에서 2 리소스를 읽습니다. 29>pch.cpp 29>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): error C2220: the following warning is treated as an error 29>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss 29>Done building project "KeyboardManager.vcxproj" -- FAILED. 34>------ Build started: Project: UnitTests-FancyZones, Configuration: Debug x64 ------ 34>FancyZonesSettings.Spec.cpp 34>JsonHelpers.Tests.cpp 34>C:\Users\hyunh\Documents_Project\PowerToys\src\modules\fancyzones\tests\UnitTests\FancyZonesSettings.Spec.cpp(1,1): error C2220: the following warning is treated as an error 34>C:\Users\hyunh\Documents_Project\PowerToys\src\modules\fancyzones\tests\UnitTests\FancyZonesSettings.Spec.cpp(1,1): warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss 34>C:\Users\hyunh\Documents_Project\PowerToys\src\modules\fancyzones\tests\UnitTests\JsonHelpers.Tests.cpp(1,1): error C2220: the following warning is treated as an error 34>C:\Users\hyunh\Documents_Project\PowerToys\src\modules\fancyzones\tests\UnitTests\JsonHelpers.Tests.cpp(1,1): warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss 32>dllmain.cpp 32>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): error C2220: the following warning is treated as an error 32>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss 32>Done building project "FancyZonesModule.vcxproj" -- FAILED. 35>------ Build started: Project: KeyboardManagerTest, Configuration: Debug x64 ------ 33>dllmain.cpp 34>C:\Users\hyunh\Documents_Project\PowerToys\src\modules\fancyzones\tests\UnitTests\JsonHelpers.Tests.cpp(635,1): warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss 34>C:\Users\hyunh\Documents_Project\PowerToys\src\modules\fancyzones\tests\UnitTests\JsonHelpers.Tests.cpp(1750,1): warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss 30>action_runner.cpp 33>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): error C2220: the following warning is treated as an error 33>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss 33>Done building project "ColorPicker.vcxproj" -- FAILED. 36>------ Build started: Project: Microsoft.PowerToys.Run.Plugin.Calculator.UnitTest, Configuration: Debug x64 ------ 36>Microsoft.PowerToys.Run.Plugin.Calculator.UnitTest -> C:\Users\hyunh\Documents_Project\PowerToys\src\modules\launcher\Plugins\Microsoft.PowerToys.Run.Plugin.Calculator.UnitTest\bin\x64\Debug\netcoreapp3.1\Microsoft.PowerToys.Run.Plugin.Calculator.UnitTest.dll 37>------ Build started: Project: Microsoft.Plugin.Folder.UnitTests, Configuration: Debug x64 ------ 37>Microsoft.Plugin.Folder.UnitTests -> C:\Users\hyunh\Documents_Project\PowerToys\src\modules\launcher\Plugins\Microsoft.Plugin.Folder.UnitTests\bin\x64\Debug\netcoreapp3.1\Microsoft.Plugin.Folder.UnitTests.dll 38>------ Build started: Project: Wox.Test, Configuration: Debug x64 ------ 34>Done building project "UnitTests.vcxproj" -- FAILED. 39>------ Build started: Project: UnitTests-SvgPreviewHandler, Configuration: Debug x64 ------ 40>------ Build started: Project: Microsoft.PowerToys.Run.Plugin.System.UnitTests, Configuration: Debug x64 ------ 39>C:\Users\hyunh\Documents_Project\PowerToys\src\modules\previewpane\UnitTests-SvgPreviewHandler\SvgPreviewControlTests.cs(94,21,94,91): warning CA1822: Member 'SvgPreviewControlShouldSetScrollBarsEnabledPropertyWhenDoPreviewCalled' does not access instance data and can be marked as static 39>UnitTests-SvgPreviewHandler -> C:\Users\hyunh\Documents_Project\PowerToys\src\modules\previewpane\UnitTests-SvgPreviewHandler\bin\x64\Debug\netcoreapp3.1\UnitTests-SvgPreviewHandler.dll 39>Done building project "UnitTests-SvgPreviewHandler.csproj". 41>------ Build started: Project: UnitTests-MarkdownPreviewHandler, Configuration: Debug x64 ------ 38>Wox.Test -> C:\Users\hyunh\Documents_Project\PowerToys\x64\Debug\modules\launcher\WoxTest\netcoreapp3.1\Wox.Test.dll 42>------ Build started: Project: UnitTest-ColorPickerUI, Configuration: Debug x64 ------ 30>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): error C2220: the following warning is treated as an error 41>UnitTests-MarkdownPreviewHandler -> C:\Users\hyunh\Documents_Project\PowerToys\src\modules\previewpane\PreviewPaneUnitTests\bin\x64\Debug\netcoreapp3.1\PreviewPaneUnitTests.dll 30>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss 43>------ Build started: Project: Microsoft.PowerToys.Run.Plugin.Registry.UnitTests, Configuration: Debug x64 ------ 40>Microsoft.PowerToys.Run.Plugin.System.UnitTests -> C:\Users\hyunh\Documents_Project\PowerToys\src\modules\launcher\Plugins\Microsoft.PowerToys.Run.Plugin.System.UnitTests\bin\x64\Debug\netcoreapp3.1\Microsoft.PowerToys.Run.Plugin.System.UnitTests.dll 42>UnitTest-ColorPickerUI -> C:\Users\hyunh\Documents_Project\PowerToys\x64\Debug\modules\ColorPicker\UnitTest-ColorPickerUI\netcoreapp3.1\UnitTest-ColorPickerUI.dll 44>------ Build started: Project: PowerToys.Settings, Configuration: Debug x64 ------ 43>Microsoft.PowerToys.Run.Plugin.Registry.UnitTests -> C:\Users\hyunh\Documents_Project\PowerToys\src\modules\launcher\Plugins\Microsoft.PowerToys.Run.Plugin.Registry.UnitTest\bin\x64\Debug\netcoreapp3.1\Microsoft.PowerToys.Run.Plugin.Registry.UnitTests.dll 30>Done building project "action_runner.vcxproj" -- FAILED. 45>------ Build started: Project: runner, Configuration: Debug x64 ------ 45>"C:\Users\hyunh\Documents_Project\PowerToys\src\runner\Resources.resx"에서 38 리소스를 읽습니다. 45>powertoy_module.cpp 45>main.cpp 45>centralized_kb_hook.cpp 45>settings_telemetry.cpp 45>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): error C2220: the following warning is treated as an error (compiling source file centralized_kb_hook.cpp) 45>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss (compiling source file centralized_kb_hook.cpp) 45>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): error C2220: the following warning is treated as an error (compiling source file settings_telemetry.cpp) 45>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss (compiling source file settings_telemetry.cpp) 45>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): error C2220: the following warning is treated as an error (compiling source file powertoy_module.cpp) 45>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss (compiling source file powertoy_module.cpp) 45>settings_window.cpp 45>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): error C2220: the following warning is treated as an error (compiling source file main.cpp) 45>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss (compiling source file main.cpp) 45>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): error C2220: the following warning is treated as an error (compiling source file settings_window.cpp) 45>C:\Users\hyunh\Documents_Project\PowerToys\deps\spdlog\include\spdlog\details\circular_q.h(1,1): warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss (compiling source file settings_window.cpp) 45>Done building project "runner.vcxproj" -- FAILED. 44>Microsoft.PowerToys.Settings.UI -> C:\Users\hyunh\Documents_Project\PowerToys\x64\Debug\SettingsUI\Microsoft.PowerToys.Settings.UI.exe 44>PowerToys.Settings -> C:\Users\hyunh\Documents_Project\PowerToys\x64\Debug\Settings\PowerToys.Settings.dll ========== Build: 32 succeeded, 13 failed, 34 up-to-date, 0 skipped ==========

crutkas commented 3 years ago

@enricogoir, wouldn't suppressing warning C4819 fix this?

enricogior commented 3 years ago

@crutkas it would be better to not suppress warnings. That file is not in ANSI format, despite of the warning. It's UTF-8 and I can't see any special character in it that could cause the warning. I suspect there might be something wrong with the user git configuration, that somehow converts/corrupts the file locally.

hankyulhyun commented 3 years ago

@crutkas @enricogior

I found sth looks related https://docs.microsoft.com/ko-kr/cpp/build/reference/utf-8-set-source-and-executable-character-sets-to-utf-8?view=msvc-160 (CP949 is base code page in visual studio in Korean Windows 10)

I'll try this and let you know.

If you have another idea, please tell me =)

TheJoeFin commented 1 year ago

Is this issue still relevant in v0.73? /needinfo

microsoft-github-policy-service[bot] commented 1 year ago

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 5 days. It will be closed if no further activity occurs within 5 days of this comment.