microsoft / PowerToys

Windows system utilities to maximize productivity
MIT License
110.75k stars 6.52k forks source link

[Awake] idea: add date/time as method to end #11233

Closed Jay-o-Way closed 1 year ago

Jay-o-Way commented 3 years ago

Provide a description of the new feature / enhancement

@dend Splitting of the idea as mentioned in this https://github.com/microsoft/PowerToys/issues/11148#issuecomment-839908997 because it's out of scope right now. Currently there are two settings for "Keep awake":

and I think it would be nice to also have

(suggest to use a \<DatePicker> and \<TimePicker>)

bytemybitz commented 3 years ago

As per #12154 I would like to see a start/end as well, but even better would be a scheduling system. I'd like to be able to say 'enable Awake from XX:XX to YY:YY' with an optional date or recurrence option like 'every [day|M|T|W|R|F|S|S]', like setting a meeting.

Jay-o-Way commented 3 years ago

Maybe schedule can be done via Task Schedular?

bytemybitz commented 3 years ago

The task scheduler doesn't have an option to terminate at a specific time, only to kill the process after X time so I'd have to create a second task to kill it at the appropriate time. Still, I've set up a task to see what happens.

Cheers, Ben

On Sat, Aug 7, 2021 at 4:15 AM Jay @.***> wrote:

Maybe schedule can be done via Task Schedular?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/microsoft/PowerToys/issues/11233#issuecomment-894635125, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMVY6R5WBAW6RGLTPHX75BTT3UBVFANCNFSM44Y6K5WA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

bytemybitz commented 3 years ago

Awake did start (as expected) using the Task Scheduler. Left this open on my screen: image which provided the insight I should be able to add --time-limit to the Action in order to have it run only for the duration I'd like it to. This does provide a workable solution for me, though I don't know what percentage of users would a) want this b) know how to do it through the task scheduler.

bytemybitz commented 3 years ago

Also not sure how to make it run in the system tray without the cmd window when starting from Task Scheduler.

Jay-o-Way commented 3 years ago

Maybe the developers (like @dend) can work this out. A start with task scheduler and an end with an internal time-keeping function?

bytemybitz commented 3 years ago

Yeah, I've added the --time-limit to my scheduled task. Aside from the cmd window this should meet my specific needs, though not average user friendly.

Your original request is easier to implement since it can be accomplished with a date/time entry and just calculating the seconds between start time and desired end time and passing that to the existing --time-limit. My scheduler request is far more complicated.

wrgrant commented 3 years ago

I see that this issue is being listed as the original for a handful of other requests that specifically ask for a scheduled 'enable' functionality.

I think this is either incorrect, or the title of this issue needs to change.

This issue started as looking for a date/time picker as another option for the 'end' event. But this still requires a user to manually initiate the start event.

True hands-off scheduling was only raised as a comment on this issue, and is a separate work item in my opinion.

davesk1 commented 3 years ago

Awake did start (as expected) using the Task Scheduler. Left this open on my screen: image which provided the insight I should be able to add --time-limit to the Action in order to have it run only for the duration I'd like it to. This does provide a workable solution for me, though I don't know what percentage of users would a) want this b) know how to do it through the task scheduler.

How did you get that to work in Task Scheduler? Out of the box, when I try it, it doesn’t wake things up and task scheduler shows an error after the start time. Can you post a screenshot shot / shots of the task scheduler entries you used? I’m assuming it doesn’t like my parameters but they match what the documentation describes. Thank you.

bytemybitz commented 3 years ago

Here's my settings. I'm not 100% sure they're working the way I want though. I'll watch and see. The terminal window isn't there anymore, Awake is running, the History shows Task Scheduler did run it. But in the system tray Awake says 'Keep screen on' 'Indefinitely'. image

image

image

image

image

davesk1 commented 3 years ago

Thanks. That matches the format of my parameters and options so that’s not the difference. I just tried it again though and it still didn’t work. It did not wake up the computer. The result showing in the Scheduler is (0x1). That’s consistent with a different post I found where someone said theirs wasn’t working either. Do you have a different result code?

Jay-o-Way commented 3 years ago

But in the system tray Awake says 'Keep screen on' 'Indefinitely'.

Yeah, to my knowledge, the communication between tray icon menu & settings gui & background is pretty bad indeed.

bytemybitz commented 3 years ago

image

I'll try to remember to make sure Awake is disabled tonight and see what state it's in tomorrow morning. No promises. 🤞

bytemybitz commented 2 years ago

Yeah. I think it is starting but it's ignoring the options I'm passing in b/c it's set to indefinite when I log in.

SoCalDude commented 2 years ago

Currently, I use the "Caffeine" tool to keep my PC awake. If Awake had a shortcut key and the ability to set a time limit on how long to keep it active, I will switch over to using Awake.

dend commented 1 year ago

Currently working on fleshing this feature out - the next release should have an end time/date associated with it.

dend commented 1 year ago

This is in #24183.

dend commented 1 year ago

PR is merged, so closing this issue - should be available in the next release of PT.

Jay-o-Way commented 1 year ago

Good news! But let's close it when it is released - as is the habit.