search

microsoft / PowerToys

Windows system utilities to maximize productivity
MIT License
111.04k stars 6.54k forks source link

File content search in Windows Search plugin #12940

Open NuraliMedeu opened 3 years ago

NuraliMedeu commented 3 years ago

Description of the new feature / enhancement

A toggle for enabling file content search in the Windows Search plugin for PowerToys Run.

Scenario when this would be used?

Scenario 1

A user wants to find a specific document among many similarly named files with different content (e.g. "lesson 12.pdf", "lesson 13.pdf", "lesson 14.pdf") based on words or phrases inside it because they don't remember the document's exact name.

Scenario 2

A user wants to find all books and/or documents which share specific concepts but are named differently and/or don't feature the concept in their names (e.g. all history textbooks containing "Genghis Khan").

Supporting information

It's uncomfortable to use two or more tools (e.g. PowerToys Run, Open-Shell Menu and/or File Explorer) for one purpose (general search).

NuraliMedeu commented 3 years ago

I am aware that similar issues have already been raised, namely #4972 and #8353; however, both of them suggest creating a new PT Run plugin for file content search, whereas I am suggesting to extend the functionality of the existing Windows Search plugin, because Windows Search in File Explorer already has this feature.

NuraliMedeu commented 3 years ago

I started to work on the issue. The feature will probably be complete by December 2021, because I am also busy with my university courses.

NuraliMedeu commented 3 years ago

@crutkas, @enricogior, what do you think of this issue?

crutkas commented 3 years ago

I'm ok with the tweaks proposed to the plugin, I think you do need enhanced search enabled however to search content so you'll have to be sure that scenario is handled.

i'd suggest this option be off by default as this is a much more costly search.

What are your thoughts about these types of details @NuraliMedeu? You've spent more time chances are thinking here so would love your insight

NuraliMedeu commented 3 years ago

Thank you for reminding about enhanced search settings, I will consider it. Also, sorry for forgetting to mention this in the issue, but I intended this feature to be off by default, because, as you mentioned, it's more expensive.

crutkas commented 3 years ago

For enhanced search, we already have some areas that look for it but for what you are wanting to do, pretty sure it has to be on.

cherryamme commented 2 years ago

Is it possible to search for file content now? I can't find an enhanced search settings about it @NuraliMedeu

cherryamme commented 2 years ago

Is it possible to search for file content now? I can't find an enhanced search settings about it @NuraliMedeu

@crutkas

NuraliMedeu commented 2 years ago

I am sorry, but I have not made progress since I was assigned. Frankly, I am too inexperienced in C# programming to accomplish it right now. Someone who knows how Windows Search works and can be accessed via C# should continue this.