search

microsoft / PowerToys

Windows system utilities to maximize productivity
MIT License
110.62k stars 6.52k forks source link

[FancyZones Editor] Merge zones after resizer deletion #12983

Open SeraphimaZykova opened 3 years ago

SeraphimaZykova commented 3 years ago

In https://github.com/microsoft/PowerToys/pull/12969 was added an opportunity to delete resizer in a grid layout. After the resizer was deleted, all zones adjacent to that resizer are merged. In some cases, when coordinates and sizes of zones match, another way of merging is more preferable, e.g. for a 4-zones grid:

Expected: expected_merge

Actually: actual_merge

In other cases, the way to merge should be as it is.

other_examples

Jay-o-Way commented 3 years ago

The first example (expected versus actual) is clear to me. I wonder about the last one. 1 and 2 stay as they were (only the width is reset to 50%?) but 3 and 4 are merged. Why the difference between "zones above" versus "zones below" splitter? Why is the result not like the top-right image here? [ 1 | 2 ] (1+3 and 2+4)

SeraphimaZykova commented 3 years ago

@Jay-o-Way perhaps I described it not clear enough. The last two images are just different cases. In both last cases, the only way we can handle the deletion of the dotted resizer is to merge all four (or three) in a single zone.

Jay-o-Way commented 3 years ago

Oh yes, nevermind then :)

crutkas commented 2 years ago

how much work is here? small / medium / large?