search

microsoft / PowerToys

Windows system utilities to maximize productivity
MIT License
111.47k stars 6.56k forks source link

ctrl to wake up can cause find my mouse trigger on wake #14098

Open StainlessSteele opened 3 years ago

StainlessSteele commented 3 years ago

Microsoft PowerToys version

0.49.0

Running as admin

Area(s) with issue?

Mouse Utilities

Steps to reproduce

Surface Laptop using a Microsoft Sculpt Comfort USB connected BT keyboard. Using they keyboard double-press ctrl to wake the machine. When the machine wakes, the mouse finder shortcut has been recognized by PowerToys and has my pointer in a highlighted circle PowerToysReport_2021-10-29-11-49-17.zip .

✔️ Expected Behavior

To not have my mouse highlighted as I had pressed those keys to simply wake my computer.

❌ Actual Behavior

my mouse is highlighted.

Other Software

No response

Jay-o-Way commented 3 years ago

Sorry if this was unexpected. It's a new feature. You happen to use the exact method to trigger this.

StainlessSteele commented 3 years ago

Of that I am aware, Clint asked me to open this as he's of the mind that since I am pressing the keys to wake the machine and it's locked, it shouldn't carry this key-press into the desktop interface to show this.

Jay-o-Way commented 3 years ago

Oh i see. If he meant locked, he would be right, but sleeping state is not the same thing.

StainlessSteele commented 3 years ago

wake from sleep, and then the machine is locked and needs creds to unlock.

crutkas commented 3 years ago

@jaimecbernardo @StainlessSteele is an internal employee. We can sync with him but we shouldn't be triggering if lock is up.

I can try when i'm at home with my surface keyboard + desktop but i cannot repo on a surface laptop 2 only

JacksonCampbell99 commented 3 years ago

This is literally the way I always wake up my computer.

crutkas commented 3 years ago

@JacksonCampbell99 happens for you as well? @StainlessSteele is it unlocked via Hello or password/pin?

crutkas commented 3 years ago

@jaimecbernardo are you able to repro?

StainlessSteele commented 3 years ago

Unlock is via Hello.

JacksonCampbell99 commented 3 years ago

@crutkas It has not been happening right now due to my Surface Book base being out of commission for now and me putting my computer on hibernate instead of sleep recently, so I'm unlocking by power button and Windows Hello. I was commenting that when using a computer on sleep with a keyboard, historically this is exactly how I wake it up as well.

StainlessSteele commented 3 years ago

So, locking the screen and hitting double control doesn't bring this up. But closing the laptop's lid, hitting double control and then waiting till the external display turns on, then opening the laptop and unlocking via hello, that's what then gives me the mouse finder being activated. Just repro'd.

jaimecbernardo commented 3 years ago

I've reproduced this successfully on a surface pro 7 with keyboard.

crutkas commented 3 years ago

@jaimecbernardo think we should see if we can't prevent this but feels lower priority versus a must fix now for the Nov release. (thinking a Jan 2022 item)

If anyone reallllly disagrees with me, please speak up.