Keyboard Manager re-mapped keys are ignored in Power Toys UI

microsoft / PowerToys

Windows system utilities to maximize productivity

MIT License

111.35k stars 6.55k forks source link

Keyboard Manager re-mapped keys are ignored in Power Toys UI #14220

Open sgllama opened 3 years ago

sgllama commented 3 years ago

After applying a re-map using the Keyboard Manager - specifically, mapping CAPS LOCK to WIN on a keyboard without a dedicated WIN key - it is not possible to use the 'new' WIN key to create any shortcuts in the rest of the Power Toys UI: the key is still seen as CAPS LOCK by the UI.

For example, trying to change "Mute microphone" to WIN + N from WIN + SHIFT + N is impossible:

there is no dedicated WIN key to press
pressing CAPS LOCK is not remapped to WIN even though we are no longer within the "Keyboard Manager's Remap keys" dialogue box (which should be the only place where the re-mapping is not valid)

jaimecbernardo commented 3 years ago

PowerToys modules and the way we detect shortcuts are set in a way that they try not to interfere with each other when setting shortcuts in settings.

One way to get around this would be to have some sort of manual input for setting keys through comboboxes like in remap shortcut.

The current workaround for the VCM shortcut issue would be to exit PowerToys, go into %LOCALAPPDATA%\Microsoft\PowerToys\Video Conference in file explorer and edit settings.json. There you can add the Windows Key to the shortcuts by changing "win":false to "win":true on the shortcuts you want to change. Then, start PowerToys again.

crutkas commented 2 years ago

@jaimecbernardo this is a can't easily fix issue, correct? Maybe we have a dialog that suggests for modifier remaps we suggest to restart powertoys?

jaimecbernardo commented 2 years ago

It's more that we don't let mappings affect the setting of other shortcuts. Perhaps the right way here would be to apply the keyboard manager mappings when setting shortcut keys for other PowerToys, but his needs some testing to understand if they're conflicting or being mapped when actually applying the shortcut, and by which order they're being processed.

Some investigation needs to be done here to understand the nuances of our current implementation of keyboard hooks and how we're handling the edit shortcut screen.