microsoft / PowerToys

Windows system utilities to maximize productivity
MIT License
109.89k stars 6.48k forks source link

[Dev] Wox Tests > QueryBuilderTest: Exception in PT Run's log #15141

Open htcfreek opened 2 years ago

htcfreek commented 2 years ago

Microsoft PowerToys version

0.1.0

Running as admin

Area(s) with issue?

PowerToys Run

Steps to reproduce

Start the QueryBuilderTest in Wox Tests.

✔️ Expected Behavior

Nu errors in log file.

❌ Actual Behavior

[2021-12-25 14:06:58.8700] [ERROR] [D:\AppDev\Github\htcfreek\PT_RunKeywordFix\src\modules\launcher\Wox.Plugin\PluginPair.cs::141]
-------------------------- Begin exception --------------------------
Message: Couldn't load assembly for  in 

Exception full name  : System.ArgumentNullException
Exception message    : Value cannot be null. (Parameter 'assemblyPath')
Exception stack trace:
   at System.Runtime.Loader.AssemblyLoadContext.LoadFromAssemblyPath(String assemblyPath)
   at Wox.Plugin.PluginPair.CreatePluginInstance() in D:\AppDev\Github\htcfreek\PT_RunKeywordFix\src\modules\launcher\Wox.Plugin\PluginPair.cs:line 135
Exception source     : System.Private.CoreLib
Exception target site: System.Reflection.Assembly LoadFromAssemblyPath(System.String)
Exception HResult    : -2147467261
-------------------------- End exception --------------------------

Other Software

No response

crutkas commented 2 years ago

should this have failed the test?

htcfreek commented 2 years ago

The test passing as expected. But I think the test should not produce an exception we have only on running tests.

crutkas commented 2 years ago

How did the test throw an exception but still pass. It feels like it should have failed.

htcfreek commented 2 years ago

How did the test throw an exception but still pass. It feels like it should have failed.

The test creates dummy plugins in memory and use them to evaluate different search queries. The dummy plugins don't jave a plugin directory which causes the stack trace.

TheJoeFin commented 1 year ago

Is this issue still relevant in v0.73? /needinfo

htcfreek commented 1 year ago

This exception still occours in v0.73.0 .