search

microsoft / PowerToys

Windows system utilities to maximize productivity
MIT License
109.89k stars 6.48k forks source link

Implementation for Wox.Plugin.ISettingProvider.CreateSettingPanel in PT Run #18233

Open mklprudence opened 2 years ago

mklprudence commented 2 years ago

Description of the new feature / enhancement

I think it would be great to implement CreateSettingPanel for additional setting options other than the current boolean PluginAdditionalOption

Scenario when this would be used?

This will add additional settings option for plugins such as ListBox, and allow greater flexibility for settings option.

Supporting information

No response

thgossler commented 3 months ago

CreateSettingPanel seems to be required to be implemented now by the ISettingProvider interface. But it is never called by the Launcher and all implementations just throw a NotImplementedException.

Would be great if this interface would be called and the returned Control be embedded into the plugin setting UI below or instead of the other PluginAdditionalOptions. In case a plugin is throwing a NotImplementedException it would just be ignored.

Currently, I'm just opening a config file in the default editor as replacement for a SettingPanel for direct editing when the user checks a checkbox.