search

microsoft / PowerToys

Windows system utilities to maximize productivity
MIT License
111.94k stars 6.6k forks source link

Keyboard manager does not disable hotkeys when they are "rolled" #18459

Open ujl123 opened 2 years ago

ujl123 commented 2 years ago

Microsoft PowerToys version

v.058.0

Running as admin

Area(s) with issue?

Keyboard Manager

Steps to reproduce

  1. set up a remap to win + E and set that to disable on all apps
  2. set up a remap to win + V and set that to disable on all apps

A quick definition of how I'm using the term "rolled". While holding down lwin, Hold E then hold V, When doing the lwin + E OR lwin + V shortcut it correctly clears the hotkey. However if you "roll" the hotkey by holding down lwin + E + V you can see it no longer overriding it with left click oemclear anymore.

In the attached video you can see that at around 4 seconds the clipboard history fires off (lwin + v) and right after the explorer fires off (lwin+E)

The keyboard overlay on the left side also shows the key press sequences and the vs code window has a summary of what I'm trying to demonstrate.

https://user-images.githubusercontent.com/13132548/170129123-7314910c-3b1a-4740-bbd1-f93655376925.mp4

✔️ Expected Behavior

I had expected it to not allow those hotkeys through when rolled. OR to allow definitions of LWIN+E+V to be defined so that it can also be set to disabled. The second ask might be a weird one because it's not often that people chord two or more keys after holding down a modifier.

❌ Actual Behavior

fires off the disabled hotkeys when you roll two keys together even though these are keys set to disabled.

Other Software

No response

paradokx commented 2 years ago

Reproduced Issue

Version 0.59.0 ✔Running as administrator

Case

Screenshot 2022-06-12 130413

Shortcuts not rolled.

  1. winkey + e

  2. winkey + v

    -> Nothing happens, as expected.

202206_keyboardmanager_disabled

Shortcut rolled

  1. winkey + e + v
  2. winkey + v + e

-> Both shortcuts are registered.

202206_keyboardmanager_rolled

jaimecbernardo commented 2 years ago

Interesting. Thanks for the report. I can reproduce this.

ujl123 commented 2 years ago

@ujl123 What is the status in the latest version? this has not been resolved yet.

bbartels commented 5 months ago

Would https://github.com/microsoft/PowerToys/pull/32125 fix https://github.com/microsoft/PowerToys/issues/10393 as well?

EDIT: Just confirmed by compiling locally this does actually fix https://github.com/microsoft/PowerToys/issues/10393 🎉