search

microsoft / PowerToys

Windows system utilities to maximize productivity
MIT License
108.37k stars 6.4k forks source link

[MeasureTool - ScreenRuler] Add units of measure to tooltip #20049

Open htcfreek opened 2 years ago

htcfreek commented 2 years ago

Showing an indicator about which number is X (left/right) and which is Y (up/down) when measuring in rectangle mode and cross mode.

I like it, but since we're going to allow different display units of measure soon, it could look a bit cluttered, i.e. "W:10px H: 20px". 🤔

Can we have a line break like this:

Width: 10px
Hight: 20px

Then it looks cleaner.

Originally posted by @htcfreek in https://github.com/microsoft/PowerToys/pull/19701#issuecomment-1221405872

cc: @yuyoyuppe

yuyoyuppe commented 2 years ago

@niels9001 any feedback on this? :)

Jay-o-Way commented 2 years ago

How does it deal with display scaling? Any reminder for the user? Since actual pixels are not changed.

yuyoyuppe commented 2 years ago

@Jay-o-Way It measures the number of actual pixels on screen, but we could add other options, e.g. "DPI-independent pixels". It doesn't make a lot of sense in general though, since not all apps properly handle different DPIs.

Jay-o-Way commented 2 years ago

True. Pixels == pixels :)

niels9001 commented 2 years ago

@niels9001 any feedback on this? :)

@yuyoyuppe @htcfreek I personally don't see the advantage:

One UI update related to this I could imagine is making the 'x' lighter gray so the Width/Height values catch the users eye better.. but that's a nice to have ;-)

@Jay-o-Way Device DPI could be handy - but maybe make it into an selectable option / format then? Like the 'preferred format' in ColorPicker?

Jay-o-Way commented 2 years ago

making the 'x' lighter gray

And make it a × character, not a letter.

htcfreek commented 2 years ago

@jay-o-way, @niels9001 Please create a separate issue for the dpi thing.

yuyoyuppe commented 2 years ago

Good suggestion, changed to utf char. As for making × lighter, we need to implement custom renderer and custom effect class like this tutorial shows. Could be a good first issue 🙂

htcfreek commented 2 years ago

Good suggestion, changed to utf char. As for making × lighter, we need to implement custom renderer and custom effect class like this tutorial shows. Could be a good first issue 🙂

I saw you implemented it. Is this issue then resolved (except for the device dpi feature)?

yuyoyuppe commented 2 years ago

Yes. Maybe we could repurpose this issue for adding support of units of measure.