microsoft / PowerToys

Windows system utilities to maximize productivity
MIT License
111.14k stars 6.54k forks source link

Quick Accent: Releasing Shift key before inputting activation key display lowercase characters #20324

Open wmentha opened 2 years ago

wmentha commented 2 years ago

Microsoft PowerToys version

0.62.0

Running as admin

Area(s) with issue?

Quick Accent

Steps to reproduce

  1. Hold Shift Key
  2. Hold a
  3. Release Shift Key
  4. Enter Activation Key

✔️ Expected Behavior

Quick Accent remembers the last typed character was uppercase a and displays uppercase a accents in the toolbar.

❌ Actual Behavior

Quick Accent displays lowercase a accents.

Other Software

No response

wmentha commented 2 years ago

@Aaron-Junker @jaimecbernardo Is it alright if I work on this? Made a start with https://github.com/wmentha/PowerToys/commit/42dbd468addcbd15780e3f8b361928856853bc5a in my branch CaseActivationFix. It moves the uppercase/lowercase state detection to C++

jaimecbernardo commented 2 years ago

This would be a good contribution. Thanks for helping out.

cinnamon-msft commented 1 week ago

I'm not able to repro this, are you still experiencing this issue? /needinfo

wmentha commented 1 week ago

I'm not able to repro this, are you still experiencing this issue? /needinfo

Hi there! Sorry I never got around to finishing this. But yes, this issue still exists: image