microsoft / PowerToys

Windows system utilities to maximize productivity
MIT License
107.39k stars 6.34k forks source link

Windows Terminal (and other apps) can't be shift-dragged to a zone #209

Closed 0xabu closed 4 years ago

0xabu commented 4 years ago

Trying out FancyZones, I discovered that the new Windows Terminal can't be shift-dragged into a zone. All the other apps I'm using seem to work, but holding down shift while dragging the terminal window just moves the window as normal and won't snap to a zone. Win+arrow doesn't seem to work specially for it either.

810 commented 4 years ago

confirmed, looks like the terminal is hacking into the explorer.

indierawk2k2 commented 4 years ago

Great bug! I verified it too. We'll investigate

gmontanola commented 4 years ago

Just to add another application with the same problem: Telegram Desktop can't be shift-dragged too.

Both are Windows Store apps but other apps like Spotify and WhatsApp Web work properly.

Polyterative commented 4 years ago

This also happens when using maxto, a paid alternative. I guess the underlying API is the same

mineral4x commented 4 years ago

Does this possibly affect all Win store apps on the UWP platform?

enricoreich commented 4 years ago

It's also the case with ConEmu and if you have General->Appearence:Hide captions always option activated and General->Tab bar: Tabs on bottom option deactivated.

If so, the zones are not shown if you drag the ConEmu window and press shift.

@mineral4x: It works with the weather app and windows 10 calculator.

awildbrysen commented 4 years ago

The Epic Games store and Origin have this issue as well

tssge commented 4 years ago

It seems like there's something about Qt that makes windows unable to be snapped in place.

Telegram is made with Qt, Origin is made with Qt (I believe) and a Discord client I use, Ripcord, is made with Qt and is undraggable as well.

jokeyrhyme commented 4 years ago

This has been reported over in the Windows Terminal project: https://github.com/microsoft/terminal/issues/2689

jopose commented 4 years ago

Edge in Application Guard can not be dragged to FanzyZones zone. Same behaviour for Edge Dev in Application Gurard.

lotsahelp commented 4 years ago

I can't get Chrome (76.0.3809.132) to snap either. Firefox 69 does. Edge does.

enricogior commented 4 years ago

We have found the root cause and we are working on a fix, stay tuned ;)

DHowett-MSFT commented 4 years ago

confirmed, looks like the terminal is hacking into the explorer. @810

Hi. Terminal dev lead here. We're definitely not "hacking into the explorer", we're just using traditional non-client painting techniques. That's.. a very strange accusation.

enricogior commented 4 years ago

Hi @DHowett-MSFT feel free to close the bug that has been opened on the Terminal repo, this is not a bug in Terminal, it's a problem with the way we detect if the window is being moved or resized, the fix is on the way. Thank you.

enricogior commented 4 years ago

The fix is in master, if you don't want to wait for the next release, you can build it and give it a try!

jopose commented 4 years ago

This doesn't work with MS Edge in Application Guard. MS Edge version: 44.18362.10024.0

It also doesn't work in the new MS Edge (Dev) MS Edge(dev) version: 79.0.309.5 (Official build) dev (64-bit)

PowerToys version: 0.12.0.0

enricogior commented 4 years ago

Hi @jopose I haven't tested it with Application Guard yet, but I tested it with Edge Chromium Dev Version 79.0.309.5 and it works fine. Can you make sure you are running v0.12.0? Thanks.

enricogior commented 4 years ago

@jopose when you drag Edge, the zones don't show up or they show up but Edge doesn't get snapped into the selected zone?

jopose commented 4 years ago

Yes, I'm running 0.12. And yes, it works with Edge Chromium and regular Edge. It seams as if it's Application Guard that is the problem.

jopose commented 4 years ago

The zones don't show up.

enricogior commented 4 years ago

@jopose can you please open a new issue specific to Application Guard, since the bug seems to be different from the one that was effecting windows with custom title bars. Thanks.

allansramblings commented 4 years ago

The Sound Control panel (where you swap audio sources, etc) doesn't allow shift dragging or snapping. At least for me.

enricogior commented 4 years ago

Hi @allansramblings you mean this one? image

allansramblings commented 4 years ago

Yes that one.

jccraig commented 4 years ago

Python IDLE windows are now not snapping into a frame fore me. They worked fine until recently.

crutkas commented 4 years ago

@jccraig, you are on 0.15?

enricogior commented 4 years ago

@jccraig can you add you report here https://github.com/microsoft/PowerToys/issues/1466? Thanks.

ElectroLund commented 4 years ago

Super obscure example to throw on the pile... CVI LabWindows by National Instruments.

Its main window and all it's little undocked windows, none of them respond.

CVI undocked

Now strangely, FancyZones did work with this application in an earlier release. Sorry I don't remember which one. But in the last 2 or 3 releases on, FancyZones doesn't recognize the app.

enricogior commented 4 years ago

Hi @ElectroLund in the early releases FancyZones was accepting basically every window, but it was causing a lot of problem since it was not treating dialog and child windows as they should, causing several bugs. We make some changes to prevent those bugs and that had the side effect of not being able to move certain windows. Now we try to add support for those windows on a per case basis.

ElectroLund commented 4 years ago

Gotcha, @enricogior. Any chance we can get our specific app added to the "whitelist"?

enricogior commented 4 years ago

We have two approaches to this:

ElectroLund commented 4 years ago

Awesome! The 1st option is a pain to you devs and presents an "playing catch-up" forever. It's also difficult with my app, because it's a paid suite, so a hassle for you.

I vote for #2, as it puts the responsibility on the user.

ziplock9000 commented 4 years ago

Just to add another application with the same problem: Telegram Desktop can't be shift-dragged too.

Both are Windows Store apps but other apps like Spotify and WhatsApp Web work properly.

Furthermore Telegram breaks it for ALL other apps on my system. Telegram has to be stopped, PowerToys has to be stopped and restarted for it to work again.

enricogior commented 4 years ago

Hi @ziplock9000 can you please provide more information:

ziplock9000 commented 4 years ago

Hi @ziplock9000 can you please provide more information:

  • what version of PowerToys are you running?
  • what are the exact repro steps and does it happen all the times?

v0.17.0 and it happens 100% of the time. 1) Start PT 2) Start Telegram 3) Attempt to shift-drag a window.. nothing happens

Steps 1 and 2 can be swapped, it makes no difference.

enricogior commented 4 years ago

@ziplock9000 please check if it still happens with 0.18 https://github.com/microsoft/PowerToys/releases

ziplock9000 commented 4 years ago

@ziplock9000 please check if it still happens with 0.18 https://github.com/microsoft/PowerToys/releases

That's fixed it, thanks!.

coxse commented 4 years ago

Just adding another app that doesn't snap into zones, "S3 Browser"

using powertoy ver v0.18.2

enricogior commented 4 years ago

@coxse this is a closed issue, please add your comment to https://github.com/microsoft/PowerToys/issues/1466 Thanks.

codingbott commented 4 years ago

Also Teamspeak 3 cant dragged to zones. Zones do not appear.

DHowett commented 4 years ago

@codingbott this is a closed issue, please add your comment to #1466 Thanks.

ThatGirlSlays commented 4 years ago

Same issue with OBS Studio (using version 23.1.0 64 bit)

Edit. I will move my comment to #1466

rcuhljr commented 3 years ago

https://parsecgaming.com/ stopped snapping after the last power tools update for me, latest versions (150-46)

zigurana commented 2 years ago

This is still an issue with PT v0.45 and Windows Terminal Version: 1.8.1521.0.

As this seems to be the main issue that all others refer to, maybe re-open it until it's actually fixed?

jgkawell commented 2 years ago

I'm still having this issue with the Origin Launcher on the latest PowerToys update as well.

franky920920 commented 2 years ago

@zigurana or @jgkawell Please file a new issue for this and reference this issue to track it.

hevi1991 commented 5 months ago

If your Windows terminal uses administrator mode, then powertoy also needs to use administrator mode in order to control