PowerToys Run - Unit converter - Can´t use abbreviations

[DaniDerBaer]

Microsoft PowerToys version

0.63.0

Installation method

GitHub, PowerToys auto-update

Running as admin

Yes

Area(s) with issue?

PowerToys Run

Steps to reproduce

When I type something like "10kph in mph" the unit converter plugin doesn´t recognise it. It also doesn´t change anything if I use the direct activation command.

Instead I need to type "10 kilometerperhour in mileperhour" to get a result.

This isn´t the case for all units e.g. "10ft in m" works fine.

✔️ Expected Behavior

Recognise an input if abbreviations are used and convert it correctly.

❌ Actual Behavior

Only recognises an input if no abbreviations are used.

Other Software

No response

[crutkas]

It can, like you can do 10m to in and will work, looks like this conversion needs some TLC overrides

[Tantalus13A98B5F]

You can try 10 km/h in mph, as the abbreviations are defined at https://github.com/angularsen/UnitsNet/blob/7519a2152b9389e6cf93aefe8a77fc9d80963149/UnitsNet/GeneratedCode/Quantities/Speed.g.cs#L469-L528

[GhostVaibhav]

Hi @jaimecbernardo and @ethanfangg, what does this issue need? Should we close it? Should I open a PR with the extra abbreviations for kph and mph? How should we proceed further?

[jaimecbernardo]

Hi @jaimecbernardo and @ethanfangg, what does this issue need? Should we close it? Should I open a PR with the extra abbreviations for kph and mph? How should we proceed further?

Hi @GhostVaibhav , I assume this hasn't been tested in a while. If it's still not working, I guess a PR that fixes it would be welcome. Thank you!

[GhostVaibhav]

@jaimecbernardo, I have tested it yesterday. It works with kp/h but not with kph. Also, if we decide to move forward with this, can you add the External Dependency label, since it's an issue at the UnitsNet end.

[jaimecbernardo]

@GhostVaibhav , there is something that we can do on our side as well, we are converting some units before sending them to UnitsNet: https://github.com/microsoft/PowerToys/blob/3b7adbe6acc381d11d8e17866da4b79444679c08/src/modules/launcher/Plugins/Community.PowerToys.Run.Plugin.UnitConverter/InputInterpreter.cs

[GhostVaibhav]

@jaimecbernardo Oh, my bad. It went under my radar. Maybe, I can fix it then. Could you assign it to me?

[jaimecbernardo]

Just did. Thanks a lot for picking this up 😄

[Jay-o-Way]

A few quick thoughts

• kp/h is something I've never seen before and it doesn't look right - to mean "kilometer per hour". At first, this looks more like "kilo-p(something) per hour".
• cph is something I've never seen before and it doesn't look right - to mean "centimeter per hour". I would expect "cm".
• I know mph is common enough, but technically it's ambiguous: could also be read as "meter per hour"

[GhostVaibhav]

Hi @Jay-o-Way A few quick answers -

• There is no unit as kp/h but kph. The Google search for the same shows this, making it the standard -

  

• I agree with you on this. I might remove it but I don't see any concrete reason to, since it's not conflicting with anything.

• Again, the Google search shows this, making it the standard -