search

microsoft / PowerToys

Windows system utilities to maximize productivity
MIT License
108.12k stars 6.39k forks source link

[Peek] Peek.UI persists as a media player #26755

Open AkazaRenn opened 1 year ago

AkazaRenn commented 1 year ago

Microsoft PowerToys version

0.70.1

Installation method

PowerToys auto-update

Running as admin

No

Area(s) with issue?

Peek

Steps to reproduce

  1. Start PowerToys with Peek enabled
  2. Preview a video file that it is capable of playing (not audio)
  3. Close the peek window through x on top right corner
  4. Check media player status by clicking the bottom-right corner of taskbar, where the network/volume/battery icons are
  5. Check volume mixer in settings, find PowerToys.Peek.UI

✔️ Expected Behavior

  1. Peek leaves the media player panel when the playback is stopped by the x button on the top-right corner of the window
  2. Peek does not register itself in the volume mixer when it is not in playback of a media file

❌ Actual Behavior

After the steps provided above: Screenshot 2023-06-09 092102 Screenshot 2023-06-09 092225

Note that in volume mixer, PowerToys.Peek.UI persists on the moment PowerToys starts up, regardless of whether you have previewed media files or not. I think it is not a good implementation, only apps that are actually outputting audio should appear there.

Other Software

No response

crutkas commented 10 months ago

think this is an easy fix for when window is hidden.

VojtaStanek commented 9 months ago

I belive also another way how it is seen is that after opening a video it is an "active" player and system media controls try to control it instead of other player (in my case spotify).

Steps to reproduce:

  1. Start audio playback (eg. on spotify)
  2. Pause the playback (via system controls)
  3. Preview a video file using peek powertoy and let it start playing audio.
  4. Close the peek preview window (and the video stops playing)
  5. Try to start audio playback via system controls.
  6. Expected: Spotify starts playback; Actual: Nothing happens - the system controls are in state shown on the screenshot bellow.

image

Windows 10, Powertoys v0.75

nagolucky18 commented 7 months ago

I can look at this one.

htcfreek commented 7 months ago

@nagolucky18 Feel free to investigate and fix the issue. Your contribution is welcome.

nagolucky18 commented 7 months ago

Video playback issue was resolved in 0.71. See 26160

As for the issue of Peek.UI appearing in volume mixer, this is because the app is always running if Peek is enabled. On window close, the window is hidden instead of the app being fully closed, meaning that the app stays in the volume mixer. I assume this is by design.

If removing the Peek.UI application from the sound mixer is desired, then the solution is to change Peek.UI so that it is only running when previewing media.

wDRxxx commented 1 week ago

still relevant