search

microsoft / PowerToys

Windows system utilities to maximize productivity
MIT License
111.84k stars 6.58k forks source link

[Deps]Re-evaluate workarounds after the upgrade to WASDK 1.4 #28423

Open jaimecbernardo opened 1 year ago

jaimecbernardo commented 1 year ago

Description of the new feature / enhancement

The code contains quite some workarounds due to missing features in previous versions of Windows App SDK. After https://github.com/microsoft/PowerToys/pull/28310#discussion_r1317663290, the workarounds should be evaluated for removal.

Scenario when this would be used?

Code simplification.

Supporting information

No response

dongle-the-gadget commented 1 year ago

That particular workaround mentioned still needs to be there, as AFAIK the Windows App SDK can't automatically handle title bar text foreground (most likely due to the need to support multiple UI frameworks like WPF)

Jay-o-Way commented 1 year ago

@dongle-the-gadget You mean this? https://learn.microsoft.com/windows/apps/develop/title-bar?tabs=wasdk#dim-the-title-bar-when-the-window-is-inactive

dongle-the-gadget commented 1 year ago

Yeah.

dongle-the-gadget commented 1 year ago

Maybe the "immersive dark mode" workaround could be deleted? I didn't notice it on my own app using 1.4.