search

microsoft / PowerToys

Windows system utilities to maximize productivity
MIT License
110.67k stars 6.52k forks source link

SVG not rendered correctly. #28814

Open infacto opened 1 year ago

infacto commented 1 year ago

Microsoft PowerToys version

0.74.0

Installation method

PowerToys auto-update

Running as admin

None

Area(s) with issue?

File Explorer: Thumbnail preview

Steps to reproduce

Some SVG files do not render correctly.

source.zip (svg file zipped)

✔️ Expected Behavior

Rendered in browser. rendered_browser

❌ Actual Behavior

Rendered in explorer (Win10).

rendered_explorer

Missing checkmark. (hole) Some files with hole works, other not. I cannot reproduce. I played with some styles etc in text editor. Maybe it's only on specific positions of points... I wonder if we could use a more proven/robust web renderer for SVGs (the underlaying lib of browsers).

Other Software

No response

yuyoyuppe commented 1 year ago

Hi @infacto, thanks for the report.

We do in fact use MS Edge to render previews, though it could have edge cases still that we need to fix.

Note: I've just checked this issue against PowerToys.SvgThumbnailProvider.exe@v0.73 and it's not a regression.

infacto commented 1 year ago

Ok, interesting because the "Rendered in browser" screenshot (last post) is from Edge browser and looks like expected. Why is the result different in explorer thumbnail if both uses the same renderer? ... Yes, it's no regression. It has never worked correctly in such cases. I updated from 0.6x.