search

microsoft / PowerToys

Windows system utilities to maximize productivity
MIT License
111.92k stars 6.59k forks source link

Peek Support for .eml and .msg file types #29027

Open randose opened 1 year ago

randose commented 1 year ago

Description of the new feature / enhancement

Peek could be enhanced by adding support for .eml and .msg file types.

Scenario when this would be used?

Previewing email files saved to my file system, which I do to archive important conversations.

Supporting information

No response

TheJoeFin commented 1 year ago

This is a broad issue and would be challenging to judge as "Completed" there are several overlapping issues:

26760 and #26210

Could you refine this issue to be unique and specific, otherwise this is a duplicate issue. Thanks! /needinfo

randose commented 1 year ago

This is a broad issue and would be challenging to judge as "Completed" there are several overlapping issues:

26760 and #26210

Could you refine this issue to be unique and specific, otherwise this is a duplicate issue. Thanks! /needinfo

@TheJoeFin I've reviewed the overlapping issues and refined this issue to be specific to .eml and .msg file types. I will be creating 2 more issues with other specific points that aren't already covered by other open issues. Thank you. I'm happy to hear you've implemented the MS Office file previewing capability and excited to test it out in the 0.75 Release!

dillydylann commented 1 year ago

I caught this issue a little while after the PR was merged and it's due to the .eml and .msg registry entries not having their own preview handler GUIDs. However I recently noticed that Explorer is somehow redirecting to one of the HKEY_CLASSES_ROOT\MAPI entries which does have their own handler GUID that hosts the file types. I have no idea what Explorer does that redirects to those entries without doing some hardcoding.

From ShellExView:

image

randose commented 1 year ago

I caught this issue a little while after the PR was merged and it's due to the .eml and .msg registry entries not having their own preview handler GUIDs. However I recently noticed that Explorer is somehow redirecting to one of the HKEY_CLASSES_ROOT\MAPI entries which does have their own handler GUID that hosts the file types. I have no idea what Explorer does that redirects to those entries without doing some hardcoding.

From ShellExView:

image

Strange - When I use QuickLook, the message previews properly as expected, though I'm not sure which preview handler the software uses. Peek is not able to preview the .msg files and will instead just show a summary page like it does for all other unsupported filetypes / folders / drives.

Katydid628 commented 9 months ago

Any progress on enabling peek for .msg files? Previewing outlook files was my sole reason for downloading PowerToys (I have to save and refer to a large volume of emails) so it was disappointing to find the files don't preview.

DavidGP commented 2 months ago

How come that a decade-old native Microsoft file format that is used in the millions every day is not supported?

TheJoeFin commented 2 months ago

How come that a decade-old native Microsoft file format that is used in the millions every day is not supported?

Good question. My theory is there are 2 challenges.

  1. Emails today are frequently web pages and to render a web page correctly you would need to use a web view which gets complicated when interacting with the email
  2. Emails are from external sources and contain dangerous content and attachments

I've not dug into this but I'd be interested to hear if there are other theories or if these two points really aren't an issue.