Update (x)Bindings - Githubissues

microsoft / PowerToys

Windows system utilities to maximize productivity

MIT License

107.09k stars 6.32k forks source link

Update (x)Bindings #30674

Open Jay-o-Way opened 6 months ago

Jay-o-Way commented 6 months ago

use x:Bind... in place of Binding
Remove Path=

A new binding mechanism is available for Windows 10, which is optimized for performance and developer productivity. See {x:Bind} markup extension.

Jay-o-Way commented 6 months ago

I see even more things that can be changed, but I'll save that for a follow-up pr

x:Bind Mode=OneTime is default, so doesn't need to be explicit
"XAML framework provides a built in Boolean to Visibility converter"
let's have a look at FallbackValue
let's have a look at Event Binding

https://learn.microsoft.com/windows/uwp/xaml-platform/x-bind-markup-extension https://learn.microsoft.com/windows/uwp/data-binding/data-binding-in-depth

P.S. @niels9001 did you know that the converter is basically unneeded in the toolkit?

niels9001 commented 6 months ago

@jay-o-way you mean for this: "XAML framework provides a built in Boolean to Visibility converter"?

Yeah this was added in some version of UWP/W10.. the Toolkit already existed before that and I think the Toolkit still supports versions that don't include this addition. But yeah, in WinUI 3 we don't need to use it

Jay-o-Way commented 6 months ago

There's more that I want to do. The first one is removing unneeded code for the built in converter. Can we keep this open to add/link those extras?

jaimecbernardo commented 6 months ago

This has been worked on during the 0.77 Release sprint. Please update PowerToys to the latest release: https://github.com/microsoft/PowerToys/releases