search

microsoft / PowerToys

Windows system utilities to maximize productivity
MIT License
105.15k stars 6.2k forks source link

Prefer Win-Ctrl-Shift-M instead of Windows native shortcut Win-Shift-M for Screen Ruler #32623

Open nx-frost opened 3 weeks ago

nx-frost commented 3 weeks ago

Description of the new feature / enhancement

The Screen Ruler will be bound to ⊞ Win-Ctrl-Shift-M by default.

Scenario when this would be used?

This would be useful to preserve the built-in Windows functionality which is otherwise not completely functional (desktop windows can be minimized but then cannot be restored). A user could still rebind to Win-Shift-M if they prefer.

Supporting information

When attempting to restore desktop windows minimized with the Windows built-in keyboard shortcut Win-M by using the built-in keyboard shortcut Win-Shift-M, the expected operating system functionality is overridden by the Screen Ruler.

Edit: The original proposal was to bind Ctrl-Shift-M by default, but I have changed this to ⊞ Win-Ctrl-Shift-M as it is more intuitive and similar to other PowerToys defaults and is less likely to conflict with third-party software.

Jay-o-Way commented 3 weeks ago

Hello and thanks for your message. You can change the hotkey for most modules in PowerToys Settings. Including Ctrl+Shift+M for Screen Ruler.

Jay-o-Way commented 3 weeks ago

@crutkas @ethanfangg Regarding the DEFAULT setting(s) - that's a valid point.

nx-frost commented 3 weeks ago

@Jay-o-Way Thank you, but this was not a help issue; I am well aware I can rebind the keys. This is specifically about the defaults. Please remove the tag "Resolution-Helped User". Does this need to be resubmitted as a bug? It's not really a bug, hence why I put it as a feature request.

ethanfangg commented 3 weeks ago

TIL Win+Shit+M reverts Win+M.

Ctrl+Shift+M also does something as well (not exactly sure what this is), but I could see the argument for a default shortcut change here.

Thoughts @crutas @jaimecbernardo ?

Jay-o-Way commented 3 weeks ago

Can't find a OS level function for Ctrl+Shift+M, so any existing functionality must be at app level.

nx-frost commented 3 weeks ago

An alternative proposal is Win-Alt-M. There are lots of possible choices, and I can see why Ctrl-Shift-M may be less than ideal; other programs may also make use of it—it's also a shortcut on GitHub.

jaimecbernardo commented 2 weeks ago

@ethanfangg , On previous cases where the impact seem to have been minimal, we've let the shortcut stay, as users can change the shortcut through the settings. Regarding using a new shortcut, I think we'd prefer to keep using the Windows key somewhere in the shortcut. So, perhaps "Win"+"Ctrl"+"Shift"+"M", if we end up doing it?

nx-frost commented 2 weeks ago

I think that ⊞ Win-Ctrl-Shift-M would be a bit more intuitive for users who do not happen to recall the hotkey for the Screen Ruler, since other tools tend to make use of ⊞ Win, Ctrl and Shift but largely avoid Alt.

I have edited the original proposal to reflect my opinion, and I have submitted a draft PR. If there are no qualms, it can go to review.

nx-frost commented 2 weeks ago

This is ready to go; please review at your convenience:

Jay-o-Way commented 2 weeks ago

@nx-frost thanks for your effort! Reviews (and such) may sometimes take time here. A little bit of patience is needed now and then.

nx-frost commented 2 weeks ago

For sure, just wanted to ensure there is no further action required on my part. That'll be all from me. Cheers.