Closed davidegiacometti closed 1 week ago
Any graphic changes? (looking at <Rectangle Style="{StaticResource OptionSeparator}" />
)
Any graphic changes? (looking at
<Rectangle Style="{StaticResource OptionSeparator}" />
)
No visual changes. This is https://github.com/microsoft/PowerToys/blob/41a0114efe903b268b5a2ed27a33b423aa9910ea/src/settings-ui/Settings.UI/SettingsXAML/Views/PowerLauncherPage.xaml#L644-L648
I was thinking DividerStrokeColorDefaultBrush
coulda be nice as a separator too.
Summary of the Pull Request
ItemTemplateSelector
for plugin additional optionsItemsControl
withItemsRepeater
for plugins list to improve the loading time of the pagePR Checklist
Detailed Description of the Pull Request / Additional comments
Introducing templates for plugin options didn't really improve page load time so I investigated a little bit. I profiled the page loading using
ItemsControl
andItemsRepeater
(the second one uses virtualization). Here is the comparison with a Debug build and 24 plugins loaded:The loading speed improvement it's clearly visible.
Validation Steps Performed
Manually tested Run settings page: