[DSC] Add support for ImageresizerSizes property - Githubissues

microsoft / PowerToys

Windows system utilities to maximize productivity

MIT License

105.15k stars 6.2k forks source link

[DSC] Add support for ImageresizerSizes property #32657

Open yuyoyuppe opened 3 weeks ago

yuyoyuppe commented 3 weeks ago

Summary of the Pull Request

do not use ints for enums in ImageSize struct
add required converters
extend setAdditional functionality
add relevant sample

PR Checklist

[ ] Closes: #xxx
[x] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[ ] Tests: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[ ] New binaries: Added on the required places
- [ ] JSON for signing for new binaries
- [ ] WXS for installer for new binaries and localization folder
- [ ] YML for CI pipeline for new test projects
- [ ] YML for signed pipeline
[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

applied installAndConfiguration.dsc.yaml (with the install step commented out) and verified in the settings that the sizes are appended/changed
applied configureLauncherPlugins.dsc.yaml and verified that Launcher plugins configuration still works

yuyoyuppe commented 3 weeks ago

/azp run

azure-pipelines[bot] commented 3 weeks ago

Azure Pipelines successfully started running 1 pipeline(s).

dfederm commented 2 weeks ago

/azp run

azure-pipelines[bot] commented 2 weeks ago

Azure Pipelines successfully started running 1 pipeline(s).