microsoft / PowerToys

Windows system utilities to maximize productivity
MIT License
105.16k stars 6.2k forks source link

[Peek] Connect BitmapImage to live XAML tree before setting source. #32669

Closed gokcekantarci closed 1 week ago

gokcekantarci commented 2 weeks ago

Summary of the Pull Request

https://learn.microsoft.com/en-us/windows/uwp/debug-test-perf/optimize-animations-and-media

As suggested under the "Right-sized decoding" heading, I first attached the live tree and then set source. The bug appeared to be fixed.

Note: I also tested with QOI and SVG images. I did not implement this change because I did not see any problems with these. If a similar problem occurs in a different issue, a similar solution can be applied.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

OriginalImage

The image above can be tested with the latest version and these changes to observe the differences.

Jay-o-Way commented 2 weeks ago

@dfederm we have a lot of problems with PRs giving errors, mentioning something with cache. Do you know why?

dfederm commented 2 weeks ago

@Jay-o-Way I'm looking into it right now. It only appears to be affecting pipelines runs from forks.

dfederm commented 2 weeks ago

/azp run

azure-pipelines[bot] commented 2 weeks ago
Azure Pipelines successfully started running 1 pipeline(s).
dfederm commented 2 weeks ago

@Jay-o-Way pipelines should be fixed with #32676. I'll monitor it today to make sure though.

Sorry for the disruption!

Jay-o-Way commented 2 weeks ago

Thanks!