search

microsoft / PowerToys

Windows system utilities to maximize productivity
MIT License
111.52k stars 6.56k forks source link

[Monaco] CSP has no extension associated with it in `monaco_languages.json`. #32771

Open PesBandi opened 6 months ago

PesBandi commented 6 months ago

Microsoft PowerToys version

0.80.1

Installation method

GitHub

Running as admin

None

Area(s) with issue?

File Explorer: Preview Pane, Peek

Steps to reproduce

This piece of code in monaco_languages.json.

{
    "id": "csp",
    "extensions": [],
    "aliases": [
        "CSP",
        "csp"
    ]
}

It seems that .csp files were intended to be previewable. However since extensions is empty, they aren't.

✔️ Expected Behavior

No response

❌ Actual Behavior

No response

Other Software

No response

htcfreek commented 6 months ago

cc: @Aaron-Junker

Aaron-Junker commented 6 months ago

This would have to be fixed in the monaco source code: https://github.com/microsoft/monaco-editor/blob/main/src%2Fbasic-languages%2Fcsp%2Fcsp.contribution.ts#L13

htcfreek commented 6 months ago

@Aaron-Junker Is there in issue in Monaco's repository or do you plan to open a fix PR?

htcfreek commented 5 months ago

@Aaron-Junker PR in monaco repo is merged and marked for the May release. Can you please update monaco after the release?

crutkas commented 5 months ago

fyi: Thanks all for flagging

htcfreek commented 4 months ago

@crutkas , @Aaron-Junker The monaco version including the fix was released 8 days ago. We can update our dependency.