search

microsoft / PowerToys

Windows system utilities to maximize productivity
MIT License
111.35k stars 6.55k forks source link

PowerToys Run - Query history is still collected even when the History plugin is disabled #33403

Open mike406 opened 4 months ago

mike406 commented 4 months ago

Microsoft PowerToys version

0.81.1

Installation method

WinGet

Running as admin

Yes

Area(s) with issue?

PowerToys Run

Steps to reproduce

  1. Disable the History plugin
  2. Run something through PowerToys Run
  3. Re-enable the History plugin
  4. Type !! in PowerToys Run and observe that what you ran was still collected and stored in history

✔️ Expected Behavior

I expected command history to not be collected while the History plugin is disabled

❌ Actual Behavior

When the History plugin is disabled, command history is still being collected and stored in %localappdata%\Microsoft\PowerToys\PowerToys Run\Settings\QueryHistory.json

Other Software

No response

github-actions[bot] commented 4 months ago

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

htcfreek commented 4 months ago

This is currently by design. The plugin is only a solution to access the history.

mike406 commented 4 months ago

This is currently by design. The plugin is only a solution to access the history.

That's kinda ridiculous. It's common sense that disabling History one should expect it to not be collected. If it is by design then consider it a feature request so that sensitive commands are not stored in a plain text file that is not made known to the end user. It's not documented anywhere that this is the case.