search

microsoft / PowerToys

Windows system utilities to maximize productivity
MIT License
109.73k stars 6.47k forks source link

[PowerRename] Replace syntax help window: Button tool tip is wrong #33907

Open htcfreek opened 2 months ago

htcfreek commented 2 months ago

Microsoft PowerToys version

0.82.1

Installation method

PowerToys auto-update

Running as admin

None

Area(s) with issue?

PowerRename

Steps to reproduce

Hover the i icon near the "Replace with" text box and see that the tool tip text is outdated. We added other help categories since creating the tool tip.

✔️ Expected Behavior

A text like "Replace syntax help".

❌ Actual Behavior

The text "Help for Date and Time of the file creation"

Other Software

No response

Agnibaan commented 2 months ago

can you please elaborate on this issue ? im not getting your points properly...

htcfreek commented 2 months ago

The tool tip of the info button next to the replacement text box is wrong. It says "Help for file creation date and time". but opening the help overlay show help for more syntax categories.

The help overlay shows syntax help for

Hope this helps.

Agnibaan commented 2 months ago

The tool tip of the info button next to the replacement text box is wrong. It says "Help for file creation date and time". but opening the help overlay show help for more syntax categories.

The help overlay shows syntax help for

  • file time and date
  • counter syntax
  • random character syntax

Hope this helps.

okay so you want to change the text of the info button to something like "Replace Name syntax help", Am i right ? should i work on this?

htcfreek commented 2 months ago

@Agnibaan I think that would make sense as it describes the content better.

Your help is welcome.

Agnibaan commented 2 months ago

@Agnibaan I think that would make sense as it describes the content better.

Your help is welcome.

okay then i would work on this...

htcfreek commented 2 months ago

@Agnibaan I think these are the strings to change: https://github.com/microsoft/PowerToys/blob/main/src%2Fmodules%2Fpowerrename%2FPowerRenameUILib%2FStrings%2Fen-us%2FResources.resw#L345-L350

Agnibaan commented 2 months ago

@htcfreek there is some issue im facing ... after building the installer solution i cant get the PowerToysSetup.msi file. i don't know what's wrong.

htcfreek commented 2 months ago

@htcfreek there is some issue im facing ... after building the installer solution i cant get the PowerToysSetup.msi file. i don't know what's wrong.

@Agnibaan Did you build the BugReportTool? According to this docs you need the PowerToys and the BugReportTool to build the MSI.

Or you can try if you can start PowerRename.exe stand alone without files list. As we only interested in the ui and don't need to test renaming we theoretically don't need files. (Not sure if this works.)

And last but not least I imagine that you can change the code somewhere to start PowerRename with a fake file list for benchmarks/debugging. But I never did that and don't know how to do this.

Hope this helps you.

Agnibaan commented 2 months ago

@htcfreek i m getting error while building the bugReportTool , i think that's why i cant get the installer also.

we cant get that edit window of power rename without running it properly , we need to build it first .

htcfreek commented 1 month ago

@Agnibaan Any updates?

Agnibaan commented 1 month ago

@htcfreek im facing some problem during the build process ... somehow i cant build the powerRename ... i m following the dev docs but it still not working...

htcfreek commented 2 weeks ago

@htcfreek there is some issue im facing ... after building the installer solution i cant get the PowerToysSetup.msi file. i don't know what's wrong.

@agnibaan For your information: You can debug the PowerRename UI as single project by setting it as startup project and running a debug build. image