microsoft / PowerToys

Windows system utilities to maximize productivity
MIT License
109.58k stars 6.46k forks source link

GcodePreviewHandler Frequent Crashes #34406

Open PartySausage opened 3 weeks ago

PartySausage commented 3 weeks ago

Microsoft PowerToys version

0.83.0

Installation method

PowerToys auto-update

Running as admin

Yes

Area(s) with issue?

File Explorer: Thumbnail preview

Steps to reproduce

Not reproduceable with any specific steps. but regularly get popups such as

image

or Exception Errors and can no longer preview gcode files unless I reboot the computer

✔️ Expected Behavior

Expect the previewer not to crash

❌ Actual Behavior

Previewer crashes even if the Explorer window is not in focus

Other Software

No response

similar-issues-ai[bot] commented 3 weeks ago

We've found some similar issues:

If any of the above are duplicates, please consider closing this issue out and adding additional context in the original issue.

Note: You can give me feedback by 👍 or 👎 this comment.

davidegiacometti commented 3 weeks ago

Wooow!

I have fixed several positioning issues related to preview panes, planned to be released in 0.84.0: https://github.com/microsoft/PowerToys/pull/34035

However this is is super weird since implies that the process is started without arguments 😮

https://github.com/microsoft/PowerToys/blob/e8ad4fa80488f01dfffe463b8d948233da0ece01/src/modules/previewpane/GcodePreviewHandlerCpp/GcodePreviewHandler.cpp#L169-L191

PartySausage commented 2 weeks ago

Yes, Weird indeed. Is there an eta for the 0.84.0 release? I've had some more of the same popups today & did a couple of tests. I don't know how relevant it is but there seems to be some link between minimising Windows Explorer whilst a preview of the gcode thumbnail is currently being displayed. It doesn't happen every time but when it does it seems to coincide with that action

davidegiacometti commented 2 weeks ago

0.84.0 should be released early in September, but no ETA yet.

Minimize/Restore the Explorer window is certainly a repro for some issues (you can find more details on my PR checklist https://github.com/microsoft/PowerToys/pull/34035). Are you able to reproduce with some consistency also the "wrong number of args" error?

PartySausage commented 2 weeks ago

Hi. Thanks for the info. The issue doesn't happen every time I minimise Explorer but it's pretty regular. say 8 out of 10 times. I can't identify if there are any other contributing factors or open windows that affect the frequency. I thought it might be related to multiple instances of Windows Explorer being open or some conflict with the Chrome browser but that doesn't seem to be the case. The only common thing that's triggering the issue is minimising the Explorer window whilst previewing a gcode thumbnail regardless of whether there is a window behind the Explorer window when minimised of if it just reveals the Windows Desktop

davidegiacometti commented 1 week ago

PowerToys 0.84 is released 🎉 https://github.com/microsoft/PowerToys/releases/tag/v0.84.0 Can you update and verify if the issue is still happening when using the File Explorer Preview Pane?

PartySausage commented 6 days ago

Hi David. I've updated to v0.84.0 & so far there haven't been any issues so hopefully you've nailed this one 👍🏼