microsoft / PowerToys

Windows system utilities to maximize productivity
MIT License
111.39k stars 6.56k forks source link

[Advanced Paste] Add Semantic Kernel opt-in to allow chaining of paste actions #35902

Open drawbyperpetual opened 2 days ago

drawbyperpetual commented 2 days ago

Summary of the Pull Request

See linked issue for more information.

PR Checklist

Detailed Description of the Pull Request / Additional comments

There's quite a lot of refactoring and code-quality improvements here. A non-exhaustive list:

Validation Steps Performed

htcfreek commented 1 day ago

Two cents on this:

  1. We could use an expander on the settings page. The two settings for preview and advanced AI depends on the enable AI setting.
  2. Wondering if we need a policy for this? 🤔 Thoughts?
drawbyperpetual commented 1 day ago

Two cents on this:

  1. We could use an expander on the settings page. The two settings for preview and advanced AI depends on the enable AI setting.
  2. Wondering if we need a policy for this? 🤔 Thoughts?

@htcfreek Regarding the expander for Paste with AI, I think it isn't necessary - I think we'd want to highlight the new features. It's also consistent without the expander - see Mouse Utilities for example. Having said that, you've brought up the important point that the "Custom Preview" toggle being present is tied to AI being enabled. But in this PR, I've made it also work for Image to Text. So we should untie it from AI! I'll do that..

Regarding the policy, is there any benefit that we would get by adding one given that we already one for online AI models?

htcfreek commented 1 day ago

Regarding the policy, is there any benefit that we would get by adding one given that we already one for online AI models?

Two maybe benefits I am not sure about:

But I am not sure if these are things that require a policy. 🤔

htcfreek commented 1 day ago

Having said that, you've brought up the important point that the "Custom Preview" toggle being present is tied to AI being enabled. But in this PR, I've made it also work for Image to Text. So we should untie it from AI! I'll do that..

Then we should move the toggle into tge behavior settings section.

jaimecbernardo commented 15 hours ago

/azp run

azure-pipelines[bot] commented 15 hours ago
Azure Pipelines successfully started running 1 pipeline(s).
jaimecbernardo commented 15 hours ago

Regarding the policy, is there any benefit that we would get by adding one given that we already one for online AI models?

Two maybe benefits I am not sure about:

  • Prevent using gpt-4o and force gpt3-turbo.
  • Prevent that users create complex queries that costs many credits. (Maybe we can make a max steps limit policy?)

But I am not sure if these are things that require a policy. 🤔

In terms of GPO for the feature, I'm thinking the open AI already has controls to limit credit usage / model usage per token, in case they're using a work API key 🤔 A new GPO seems not necessary at this point 😄

drawbyperpetual commented 11 hours ago

@htcfreek I've moved the Custom Preview toggle into the Behavior section as you suggested.