Open drawbyperpetual opened 2 days ago
Two cents on this:
Two cents on this:
- We could use an expander on the settings page. The two settings for preview and advanced AI depends on the enable AI setting.
- Wondering if we need a policy for this? 🤔 Thoughts?
@htcfreek Regarding the expander for Paste with AI, I think it isn't necessary - I think we'd want to highlight the new features. It's also consistent without the expander - see Mouse Utilities for example. Having said that, you've brought up the important point that the "Custom Preview" toggle being present is tied to AI being enabled. But in this PR, I've made it also work for Image to Text. So we should untie it from AI! I'll do that..
Regarding the policy, is there any benefit that we would get by adding one given that we already one for online AI models?
Regarding the policy, is there any benefit that we would get by adding one given that we already one for online AI models?
Two maybe benefits I am not sure about:
But I am not sure if these are things that require a policy. 🤔
Having said that, you've brought up the important point that the "Custom Preview" toggle being present is tied to AI being enabled. But in this PR, I've made it also work for Image to Text. So we should untie it from AI! I'll do that..
Then we should move the toggle into tge behavior settings section.
/azp run
Regarding the policy, is there any benefit that we would get by adding one given that we already one for online AI models?
Two maybe benefits I am not sure about:
- Prevent using gpt-4o and force gpt3-turbo.
- Prevent that users create complex queries that costs many credits. (Maybe we can make a max steps limit policy?)
But I am not sure if these are things that require a policy. 🤔
In terms of GPO for the feature, I'm thinking the open AI already has controls to limit credit usage / model usage per token, in case they're using a work API key 🤔 A new GPO seems not necessary at this point 😄
@htcfreek I've moved the Custom Preview toggle into the Behavior section as you suggested.
Summary of the Pull Request
See linked issue for more information.
PR Checklist
Detailed Description of the Pull Request / Additional comments
There's quite a lot of refactoring and code-quality improvements here. A non-exhaustive list:
DataPackage
) rather than on the system clipboard. The system clipboard is only read once per operation and written to only just before pasting (if needed). There are multiple reasons for this:Async
within AdvancedPaste (this was also done as part of Additional Actions but there's much more of it now).CanPreview
property (and Image to Text has been marked as having it to allow it to be previewed)lastQuery.json
functionality is removedIFileSystem
is used within Advanced Paste to improve testability.Validation Steps Performed