search

microsoft / PowerToys

Windows system utilities to maximize productivity
MIT License
111.34k stars 6.55k forks source link

Keyboard Manager - wrong shortcut detection #7007

Closed martinwronski closed 4 years ago

martinwronski commented 4 years ago

Hi I have global action mapped for shortcut: Alt+Shift+c The problem is that action is also executed when I press Alt+Shift+Control+c regards Martin

saahmedm commented 4 years ago

hi @martinwronski, I can not duplicate this behaviour. Can you please share a screenshot of your mappings and PT version?

martinwronski commented 4 years ago

PT ver 0.23 Windows 10 version 2004 image

arjunbalgovind commented 4 years ago

@martinwronski, shortcut to key remappings are executed even if other keys are pressed along with it. This is to allow users to remap something like Alt+` to Win, so that they can have an alternate Windows key if they don't have one already. So pressing Alt+Ctrl+Shift+C would do Ctrl+Play. Do you feel this should be a configurable option?

martinwronski commented 4 years ago

It would be great if there was an option to change this behaviour. Because in my situation I have Alt+Ctrl+Shift+C shortcut blocked by Play action.

saahmedm commented 4 years ago

@martinwronski @arjunbalgovind wouldn't we have to change this to execute the shortcut only on release? Meaning a shortcut is only invoked when you release keys not immediately when you invoke them. To discern between the two shortcuts, this would be a big implementational shift.

arjunbalgovind commented 4 years ago

@saahmedm For this particular scenario I don't think we would have to, since we would be making it behave identical to how shortcut to shortcut remaps work. The reason for currently keeping s2k with a different behavior was for more flexibility and allowing the user to use it for stuff like extra modifier keys, but the @martinwronski's scenario highlights cases where you might want it to behave like s2s. It would be a case of tweaking some if conditions, so it would not be a very big implementation shift. I think we could mark this as a enhancement and tweak the title accordingly.

Key to shortcut is the place where modifying it could make us run into big implementational shifts.

ghost commented 4 years ago

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 5 days. It will be closed if no further activity occurs within 5 days of this comment.