microsoft / PowerToys

Windows system utilities to maximize productivity
MIT License
110.52k stars 6.5k forks source link

[Keyboard Navigation: Settings>Keyboard Manager>Remap a Key]: Keyboard focus is lost on the window after activating 'Remap a Key' button. #7054

Open Chandresh1007 opened 4 years ago

Chandresh1007 commented 4 years ago

[Power Toys Settings- Keyboard Manager>Remap Key]

User Experience: "This will impact the keyboard users if after activating a button focus is lost on the window. "

Test Environment: "OS Version: 20221.1000 App Name: Power Toy Preview App Version: v0.23.0 Screen Reader: Narrator"

Repro-steps: "1. Open Power Toys Settings App.

  1. Naviagate to Keyboard Manager list item present in left pane and activate it.
  2. Navigate to 'Remap a key' button in right pane and activate it.
  3. Verify the issue."

Actual Result: "Keyboard focus is lost on the window after activating 'Remap a Key' button. After pressing tab key , focus lands to 'OK' button.

Note: Same issue is repro after activating 'Remap Shortcuts'."

Expected Result: "Keyboard focus is lost on the window after activating 'Remap a Key' button. After pressing tab key , focus lands to 'OK' button.

Note: Same issue is repro after activating 'Remap Shortcuts'." Keyboard focus should not be lost on the window after activating 'Remap a Key' button. It should land on 'OK' button and Screen reader should announce the opened dialog info like Remap keys Dialog Ok Button.

MAS Reference: "https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={0de7fbe1-ad7e-48e5-bcbb-8d986691e2b9} " 10_Remap key_MAS3.2.1_After activating Remap a key focus is lost.zip

arjunbalgovind commented 3 years ago

@ryanbodrug-microsoft @crutkas this is a Xaml Island quirk. I tried a couple of work arounds to fix it but none of them worked. Right now once you open the Remap key/shortcut window you need to Tab once to get to the OK button. I think rather than making a complex workaround this should be something we fix on migrating to WinUI 3.

Priyanshu073 commented 9 months ago

Issue is still repro on v 0.76.2.

https://github.com/microsoft/PowerToys/assets/87321414/7dffac65-6fa9-4ca2-8239-9d7416c7d8f4