microsoft / PowerToys

Windows system utilities to maximize productivity
MIT License
108.42k stars 6.41k forks source link

Additional items to ignore for spelling #7876

Closed crutkas closed 3 years ago

crutkas commented 3 years ago

New misspellings found, please review:

Originally posted by @github-actions in https://github.com/microsoft/PowerToys/pull/6562#issuecomment-722448646

jsoref commented 3 years ago

You're just going to want to run the command given in the To accept these changes, run the following commands in that PR (minus the misspelled word) -- once the command runs, the file will be locally updated (and hopefully staged for committing/amending). You don't really want to use a distinct PR for these things, as each PR / push will try to maintain the file.

enricogior commented 3 years ago

@jsoref is the perl script supposed to work on Windows?

crutkas commented 3 years ago

crap, ... that means i need to install perl.

jsoref commented 3 years ago

Yes, the perl script should work on windows (that's why I'm using perl instead of a shell/bash).

You can just manually add the entries to the file. If you don't add them in the right place (e.g. by appending them at the bottom), someone else who runs the perl will eventually sort the file when they get the warning.

The main line in the script is:

my @add=qw('"Actionkeyword appdata appid combobox Ctx deserialized ebf Entireitemname explr fx gwl HGLOBAL HICON hmon IEXPLORE ime IMonitor kbm lshift Multipier pipename prevpane Progman Remapper Rgn rwin scrollable scrollviewer showwindow Subdir syskeydown UAC unsubscribe userprofile VDId Wca webcam WINAPI "');

The goal is to get all the items in the double quotes added, one line at a time, to the file. The reason the line is longer than you'd expect is that it's trying to adjust for case changes, so it was first expecting to remove:

my @stale=qw('"aae abkseg actionkeyword aeroglass alfredtheme APPDATA APPID appxpackage AProduct baf bakudies basedir bfa bretan BYCOMMAND calculatorpinyindb cbegin cend cheatsheet Combobox COUNTSLABELFMT ctx deletefilefolder Deserialized desktoppreviewhandler desktopshortcutinstalled dicts dirn dropdownstypekey dropdowntypekey DString Dvs EBF Ecma ecmascript ei eig eigval eigvec ENTIREITEMNAME evt excmd executionengine EXPLR ftp Fx fxml GETDESKWALLPAPER GWL gwoyeu hanyu hglobal hicon Highcontrast hyjiacan IAlphabet IExclusive iexplore IInstant IME IMulti Indexerpinyindb Inlining isborderless Italiano jsonrpc KBHOOK KBM KListener KSeparator lastpos launcherpinyin Launcherpinyindb lbl lbx Linux listbox LSHIFT MENUSTART nc NHotkey numberbox orphanedkey osdetection Pampalona pdk PERSISTEDDATA pimpl pinyindb Pipename Plist plistlib pls Pluginpinyindb Polski Portugu POWERTOYNAME Prepends PREVPANE progman Programpinyindb Progressbar Rects reggedit remapkey remapkeyboard remapper remapshort Remoting reulst rgba rgn rk RPressed RStroked Rtc RWIN Scrollable scrollbar sessionending setings setwineventhook Shellpinyindb shortcutguide SHOWNA SHOWWINDOW Slovensk sni Srpski stefan strem stringstream subdir Subheader superfancyzones SYSKEYDOWN systemcolors Tcp temppath thr Tls tmpnam tohex transaprency TRANSPARENTGRADIENT TResult TZone uac uapmanifestschema uk Unsubscribe USERPROFILE VGr VIRTUALDESKTOPCHANGE virtualized Virtualizing vkcode vstest Walkerpinyindb wangyiyun wca wcschr wcsrchr Webcam websearch wexfs winapi winlogo winr WINTAB WORKERW wsmatch wtmpnam Xecutor xyzpreviewhandler yinle yinyue yyy ZConfig "');

-- You can see that, e.g. @stale includes remapper (which is relaxed and will not complain about REMAPPER or Remapper or remapper) and @add includes Remapper which is stricter and will only allow for Remapper.

But, you could also just copy the individual words you want from the comment piece as they appear in the "above the fold", namely:

Fwiw, it is possible to include additional advice in the bot's message. You'll probably want to tune that here based on your needs.