microsoft / PowerToys

Windows system utilities to maximize productivity
MIT License
111.28k stars 6.55k forks source link

[FancyZones] Win+Left/Right is skipping zone 2 in 0.31.1 #9524

Closed SCWells72 closed 3 years ago

SCWells72 commented 3 years ago

ℹ Computer information

📝 Provide detailed reproduction steps (if any)

I've been using PowerToys--primarily for FancyZones--pretty much since it was introduced, so first off, thanks! It's a great tool for managing content on my side-by-side 34" ultrawide monitors. My left monitor has three zones and my right monitor two. I use Win+Left/Right HEAVILY for moving windows to the desired zones. In the latest update, for some reason that function is skipping zone 2 on my right monitor. Everything else works just fine, but the zone order when using Win+Right is now L1, L2, L3, R1, R3, R4 and the reverse when using Win+Left. Notice that R2 is not included in that list. Note that I when I use Shift+Drag, zone R2 does work properly as a target.

✔️ Expected result

The expected result is a zone order when using Win+Right of L1, L2, L3, R1, R2, R3, R4 and the reverse when using Win+Left.

❌ Actual result

The actual result is a zone order when using Win+Right of L1, L2, L3, R1, R3, R4 and the reverse when using Win+Left. Again, R2 is missing.

📷 Screenshots

I'm happy to provide an animated gif showing the behavior if you'd like. Just let me know if that would be useful.

enricogior commented 3 years ago

@SCWells72 thank you for reporting the issue. We will release a hot fix. The tracker for this bug is https://github.com/microsoft/PowerToys/issues/9453

SCWells72 commented 3 years ago

@enricogior I just updated to 0.31.2 and the exact same behavior still occurs. Is there something I needed to do other than just update to the latest?

SCWells72 commented 3 years ago

@enricogior @crutkas Okay, maybe this is a feature and not a bug? The zone that's being skipped is in a layout that's arranged as follows:

image

The specific zone is denoted as 2 there. If I'm in zone 1 and use Win+Right, it goes to zone 3 instead of zone 2. If I then use Win+Left, it goes back to zone 1, again skipping zone 2. However...if I use Win+Up or Win+Down from zone 3, it goes to zone 2 and then cycles between zones 2 and 3. So it seems it's the Win+Left/Right behavior that's changed so that it takes you to the last zone in a vertical column of zones, though now Win+Up/Down allows you to cycle through zones in that column (maybe it always did?).

Certainly skipping zone 2 when using Win+Left/Right is a behavioral regression relative to previous builds, though.

SCWells72 commented 3 years ago

Also, it doesn't look like I can reopen this issue given that it still occurs under the latest build. Can one of you do so, or should I clone into a new issue so that it's back in an open status? I don't want to be a pest, so I'll wait to see whether it can be handled in the context of this existing issue for a day or two before cloning into a new one.

enricogior commented 3 years ago

@SCWells72 can you please post a screenshot of you settings for these options?

image

SCWells72 commented 3 years ago

You bet:

image

SCWells72 commented 3 years ago

FWIW, I unchecked "Move windows based on their position" and that seems to have resolved the issue. I'll play with it a bit more, but it looks promising.

enricogior commented 3 years ago

@SCWells72 if you resize zone 2 to increase its size and reduce zone 3, and using your previous settings, does the window move where you expect it? The reason might be the same as https://github.com/microsoft/PowerToys/issues/8590

SCWells72 commented 3 years ago

@enricogior These zones are explicitly sized based on editing the JSON config file directly (and have been since the very early versions). I want the zones to be 100% precise. I'm happy to provide that config file for review if you'd like, but there have never been issues prior to this build, and it seems that the new "Move windows based on their position" option causes it. For what it's worth, I only enabled that option when 0.31.1 was causing so many issues with keyboard-based window movement across zones, and unchecking it seems to restore the previous/correct behavior in 0.31.2.

enricogior commented 3 years ago

@SCWells72 you can duplicate the layout and make the change to the duplicated layout. If you make that test we will know for sure if the problem you are seeing is the same as reported in https://github.com/microsoft/PowerToys/issues/8590

LarsJandel commented 3 years ago

Hi, I've got a layout with ten overlapping zones including a full screen, seven horizontal and two vertical ones. Unfortunately it seems, the Override Windows Snap shortcut stopped working, when set by istself. When activating Move windows based on their postion as well, the override shortcut works again, but will do the position based behaviour of course. It would be great, if the override shortcut would work in standard mode again as well, as it did before. Btw, any plans for being able to access zones via a shortcut including numbers? That would save me from going through multiple zones in order to reach the desired one. 😉 Thanks. 🙏

{"uuid":"{2A103372-0CFA-4916-BD37-E93C8728A210}","name":"LJ_v1","type":"canvas","info":{"ref-width":3440,"ref-height":1410,"zones":[{"X":0,"Y":0,"width":1720,"height":1410},{"X":1720,"Y":0,"width":1720,"height":1410},{"X":0,"Y":0,"width":1146,"height":1410},{"X":1146,"Y":0,"width":1146,"height":1410},{"X":2292,"Y":0,"width":1146,"height":1410},{"X":0,"Y":0,"width":2292,"height":1410},{"X":1146,"Y":0,"width":2292,"height":1410},{"X":0,"Y":0,"width":3440,"height":705},{"X":0,"Y":705,"width":3440,"height":705},{"X":0,"Y":0,"width":3440,"height":1410}],"sensitivity-radius":20}}

FancyZones_Screenshot_2021-02-06_082432

enricogior commented 3 years ago

@LarsJandel the problem you are describing is different from the problem discussed in this issue. What version are you running? Make sure to have 0.31.2 that was just released. And in case open a new issue.

LarsJandel commented 3 years ago

Argh - sorry, sounded similar regarding a shortcut issue. And YES, the update fixed my issue [was running 0.31.1]. 🎉 Thanks for the super quick reply and the update. ...should I delete my comments from this issue entry?

enricogior commented 3 years ago

@SCWells72 I'm glad that 0.31.2 worked for you. No problem with the comment, I hid it.

ghost commented 3 years ago

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 5 days. It will be closed if no further activity occurs within 5 days of this comment.