Update build script and targeting nugets to allow the project to build on the windows-2022 image

microsoft / ProjFS-Managed-API

A managed-code API for the Windows Projected File System

Other

142 stars 34 forks source link

Update build script and targeting nugets to allow the project to build on the windows-2022 image #78

Closed yerudako closed 2 years ago

yerudako commented 2 years ago

Fixes #77. This change is combined from @cgallred's and mine changes and based on this run Christian triggered with them, it might be enough changes to use Windows 2022 (Please ignore the test failures - these are related to the symlink branch and are not present in the baseline)

Changelog:

Props file updated to reference correct Windows SDK versions
Targeting nugets used to build 4.6.1 on windows-2022 env (which only has .NET Core and .NET 4.8 present)
Redundant components removed from the vswhere check
Version limits updated in the vswhere check

ghost commented 2 years ago

All CLA requirements met.

narasamdya commented 2 years ago

Why do we need .NET 4.6.1 ? Is .NET 4.8 not sufficient?

yerudako commented 2 years ago

Why do we need .NET 4.6.1 ? Is .NET 4.8 not sufficient?

@narasamdya the project builds in 4.6.1, so I assumed that it's supposed to be used by older client apps running 4.6.1 and added the targeting pack rather than retargeting it to 4.8. I would defer to @cgallred for whether it is critical to support 4.6.1 or whether we should migrate to 4.8.

cgallred commented 2 years ago

Why do we need .NET 4.6.1 ? Is .NET 4.8 not sufficient?

@narasamdya the project builds in 4.6.1, so I assumed that it's supposed to be used by older client apps running 4.6.1 and added the targeting pack rather than retargeting it to 4.8. I would defer to @cgallred for whether it is critical to support 4.6.1 or whether we should migrate to 4.8.

It targets 4.6.1 because for a long time there had been a requirement that it needed to run on RS1 (see this PR comment). That requirement no longer exists. From what I understand of the platforms .NET 4.8 is supported on (based on this doc), 4.8 is the current Framework version on all supported OS versions, right? Plus 4.6.1 will be retired on April 26th.

I think we can update to 4.8.

yerudako commented 2 years ago

Sounds good @narasamdya @cgallred - I've updated the framework to 4.8 according to suggestions and removed the targeting packs. Seems as if both pipelines are happy with the changes.

yerudako commented 2 years ago

@cgallred thanks for reviewing! Can I also ask you to merge it - it says I am not authorized to merge the Pull Request?