search

microsoft / ProjectOxford-Apps-MimickerAlarm

Project Oxford Mimicker Alarm
Other
349 stars 89 forks source link

Adding an alarm title to a notification and changing its priority to a higher one #4

Closed piotrek1543 closed 8 years ago

piotrek1543 commented 8 years ago

Hi,

I've already done two small improvements:

  1. Changed VISIBILITY_MIN to VISIBILITY_SECRET to show an app status bar icon

The main reason of this change is that when I used Mimicker app for the first time, I felt a bit uncomfortable that there is no status bar.

According to https://github.com/Microsoft/ProjectOxford-Apps-MimickerAlarm/pull/3 I didn't noticed any clutter with notifications with similar time (I created about 10 different notifications) as it already shows only the first active one from a AlarmList.

As someone may not want to have it on his/her lock screen, according to: http://developer.android.com/reference/android/support/v4/app/NotificationCompat.html I decided to use VISIBILITY_SECRET as notification priority.

  1. Add an alarm name to a notification

Well, somebody may want to know why he/she needs to get up earlier ;-)

Screenshots

Image and video hosting by TinyPicImage and video hosting by TinyPic

I think these minimal code changes may improve a lot final app user experience.

msftclas commented 8 years ago

Hi @piotrek1543, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

delfu commented 8 years ago

Cool! we'll look into this :)

msftclas commented 8 years ago

Hi @piotrek1543, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;