microsoft / PubSec-Info-Assistant

Information Assistant, built with Azure OpenAI Service, Industry Accelerator
MIT License
266 stars 525 forks source link

Geearl/7427 backoff error #641

Closed georearl closed 2 months ago

georearl commented 2 months ago

AB#7420

This change fixes an error that occurs when a message sent to text enrichment is requeued, due to throttling for example. The code was this...

backoff = int(os.environ["ENRICHMENT_BACKOFF"])

def requeue(response, message_json): '''This function handles requeing and erroring of cognitive servcies''' blob_path = message_json["blob_name"] queued_count = message_json["text_enrichment_queued_count"] if response.status_code == 429:

throttled, so requeue with random backoff seconds to mitigate throttling,

    # unless it has hit the max tries
    if queued_count < max_requeue_count:
        max_seconds = backoff * (queued_count**2)
        backoff = random.randint(
            backoff * queued_count, max_seconds
        )

The issue being that the global var backoff is being changed within a function, which gives an error. The fix was to use a different var name downstream rather than the same var. This is the same pattern in other functions