microsoft / PubSec-Info-Assistant

Information Assistant, built with Azure OpenAI Service, Industry Accelerator
MIT License
344 stars 775 forks source link

Application Error after make infrastructure #859

Open ruandersMSFT opened 1 month ago

ruandersMSFT commented 1 month ago

Bug Details

Describe the bug After performing an infrastructure deployment via make infrastructure against a working application, the application no longer works.

Steps To Reproduce

With a working deployment, based on the latest v1.2 main release, execute a make infrastructure, allow the code to run, observed the error after infrastructure deployment.

What is the expected behavior?

The infrastructure should have not impacting changes via a redeployment of the infrastructure and the application should still operate successfully.

Screenshots image

image

Information Assistant details

Please provide the following details. You can simply include a screenshot of your Info panel as well.

GitHub branch: [e.g. main] main Version or Latest commit: [obtained by running git log -n 1 <branchname> Merge: b6c3a3b8 a1e48677 Author: Lon Tierney 93607917+lon-tierney@users.noreply.github.com Date: Thu Sep 19 19:31:15 2024 -0700

Merge pull request #857 from microsoft/vNext-Dev

Merging 1.2 features into Main

What region is your Azure Open AI Service in? EastUS2 What ChatGPT model are you using? default model name: (i.e. gpt-3.5-turbo, gpt-4) default model version: (i.e. 0613) default What embeddings model are you using? default

If the bug is confirmed, would you be willing to submit a PR?

dayland commented 1 month ago

This is a new behavior in version v1.2. As we are now using docker images for the Azure App Services and Azure Functions, we need to know the latest label of the uploaded image. At "infrastructure" deployment time the label isn't yet known, so now the terraform sets the docker image label to LATEST, thus the image isn't pulled from the Azure Container Registry. You need to now run the make deploy-functions deploy-webapp deploy-enrichments part of the scripts after make infrastructure to upload and set the proper docker image tag on the Azure App Services and Azure Function Host.

The alternative is a manual update where if you know you have a good image uploaded to the Azure Container Registry and you have not modified any of the application code, then you can: