microsoft / Purview-ADB-Lineage-Solution-Accelerator

A connector to ingest Azure Databricks lineage into Microsoft Purview
MIT License
90 stars 55 forks source link

Configurable Custom Type Name #191

Closed awbarbeau closed 6 months ago

awbarbeau commented 1 year ago

Describe the feature To improve readability and user experience in using Purview, a configurable name for the Custom Types created on Purview and referenced in the PurviewOut Function App would simplify updates beyond the default value for EntityType.

Detailed Example In Class for Purview Custom Type, the string "purview_custom_connector_generic_entity_with_columns" is assigned to EntityType. This same string is used in Infra deployment file for Purview, and the Purview Ingestion Helper, and at least one test. Instead of a specific value that must be replaced in several files, a configuration option for the custom type, that flows into all relevant components, would allow for additional flexibility during implementation.

Issues that this feature solves None that I know of.

Suggested Implementation For the .cs classes, adding a value in the settings would seem the simplest approach, and then the EntityType is updated to reference the value in each respective class.

I don't have a suggestion for the Infra Custom_Types.json, not sure how this could be done effectively.

Maintaining a default value such as "purview_custom_connector_generic_entity_with_columns" would be reasonable for implementations that don't have an ask in this space.

Additional context Thanks again for all the work on the accelerator!

wjohnson commented 6 months ago

Thank you for the suggestion! Unfortunately, we won't be able to commit to this but would be glad to take on a PR if you're interested in contributing!