microsoft / RTVS

R Tools for Visual Studio.
MIT License
390 stars 118 forks source link

[Feature Request] Additional Docker Parameters #4238

Open Neil-Schneider opened 6 years ago

Neil-Schneider commented 6 years ago

I was messing around with the new Docker container functionality. This is great stuff. Some members of my team have been using VMware's vSphere to spin up docker images. It would be very useful for us to be able to include additional parameters when creating a docker container.

An example call would look like this:

docker -H my-host --tls run -p 6056:5444 --name my-rtvs-container my-FQDN-rtvs-image:latest rtvsd

Here are some random thoughts I also had about this development:

MikhailArkhipov commented 6 years ago

I think it might be possible to create your own Docker file template. There is an option to use custom template when you create the container.

Neil-Schneider commented 6 years ago

This custom template (at least in the VS 15.5.0 release) seems to be for defining a custom docker container. Such as "my-FQDN-rtvs-image:latest". The real issue is with the -H config. Docker for windows doesn't allow for the host (-H) to be defined in a config file, but it can be called as a switch in the call to docker.

Other folks have already taken this up with the docker team, but I would like to see the ability to customize the docker call in RTVS. Even if the docker team allows for "host" values in a config file, I would want to the ability to reference different --config-files from the RTVS container set up. This would allow for connections to multiple habors/environments for dev/stage/production and for connections to different habors for different projects/products using unique config files.