microsoft / RTVS

R Tools for Visual Studio.
MIT License
390 stars 118 forks source link

"Space around =" editor setting no longer recognized at an R Interactive prompt #4264

Closed MNRK01 closed 6 years ago

MNRK01 commented 6 years ago

Hi,

I have the RTVS editor option for "Spaces around =" set to Off. This used to also work when using autocomplete at the prompt within an R Interactive session. This behavior changed a couple of months ago (I can't say exactly when, sorry...). Can the behavior for not inserting spaces around = be reestablished for an R Interactive prompt within RTVS?

Thanks for an excellent product!

Please briefly describe what you were doing that led to the issue, if applicable: Running a vanilla R session using R 3.4.3 ...

If you have any screenshots demonstrating the issue, please include them as well to help us diagnose it better.

Additional information:

OS Information Version: Microsoft Windows NT 10.0.16299.0

RTVS Information: Assembly: Microsoft.VisualStudio.R.Package, Version=1.3.31108.1213, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a

Active R URI: R 3.4.3: C:\Program Files\R\R-3.4.3

MikhailArkhipov commented 6 years ago

This option controls formatting inside function default arguments i.e. function(a=1). It has no effect on operators like x <- 1 or z = 2,

MNRK01 commented 6 years ago

Thanks for the comment. I meant that it used to work at the prompt when using autocomplete with built-in functions. I was referring to built-in functions and not to operators since autocomplete would not make sense there in any case.

e.g. autocomplete used to not put a space after the row.names argument because I had turned that Editor setting Off but today it does:

# previous behavior
data.frame(x=c(1,2,3), y=c(4,5,6), row.names=LETTERS[1:3])
# today
data.frame(x=c(1,2,3), y=c(4,5,6), row.names = LETTERS[1:3])

image

Thanks for your response.

MikhailArkhipov commented 6 years ago

Specific to the named arguments completion

MikhailArkhipov commented 6 years ago

https://github.com/Microsoft/RTVS/commit/e83ab28203c1380dae8dbb739174cbc7efa70882

MNRK01 commented 6 years ago

Wow, thanks!!