search

microsoft / ReSub

A library for writing React components that automatically manage subscriptions to data sources simply by accessing them
MIT License
606 stars 52 forks source link

React 17 / state of maintenance #246

Open dargmuesli opened 1 year ago

dargmuesli commented 1 year ago

Hey there, would it be a good idea to submit a PR that migrates ReSub to use React v17 or is ReSub EOL? Reading through https://github.com/microsoft/ReSub/issues/203 it seems possible, most likely the enzyme tests would need to support React v17, I guess. But before putting work into that I want to ask if that would make sense / if a PR would get merged. Thanks!

deregtd commented 1 year ago

State of maintenance is definitely a bit rough. I'm still using it in a personal project that's a couple years old that I'm planning on picking back up again within the next few weeks, so I'll see at that point if it needs updates for latest React. I left MSFT almost 4 years ago now, so there's no real official maintainer anymore right now. I'm not sure if anyone still has admin access to the repo. @berickson1 did you ever get access?

berickson1 commented 1 year ago

I have contributor permissions on the project. If someone wanted to work out React 17 support, I'd be happy to help support merging this

dargmuesli commented 1 year ago

Thank you for the clarification! I primarily wanted to ask, so I'm not gonna start work on a migration right away. If someone else comes across this: feel free to leave a message here if you start working on a migration. Depending on the needs of the projects I work on, I might do a migration myself at some point :)