microsoft / Recognizers-Text

Microsoft.Recognizers.Text provides recognition and resolution of numbers, units, date/time, etc. in multiple languages (ZH, EN, FR, ES, PT, DE, IT, TR, HI, NL. Partial support for JA, KO, AR, SV). Packages available at: https://www.nuget.org/profiles/Recognizers.Text, https://www.npmjs.com/~recognizers.text
MIT License
1.66k stars 429 forks source link

[DE DateTimeV2] missing frequently used expressions for "now" #3146

Open mujdricza opened 3 months ago

mujdricza commented 3 months ago

Describe the bug For the simple regex NowRegex, we miss some frequently used expressions:

To Reproduce Steps to reproduce the behavior:

  1. Go to https://github.com/microsoft/Recognizers-Text/blob/8d2eeda04e4eeef00bb00b1ae886289c84a6b67f/Patterns/German/German-DateTime.yaml#L377
  2. and see that the mentioned phrases are not present

Expected behavior The list should include frequently used phrases for "now".

Sample input/output Current status:

NowRegex: !simpleRegex
  def: \b(?<now>(genau\s+)?jetzt|momentan|im moment|derzeit|in diesem moment|aktuelle?|gerade|so früh wie möglich|frühestmöglich|neulich|vorher)\b

Platform (please complete the following information):

Additional context A possible solution:

NowRegex: !simpleRegex
  def: \b(?<now>(genau\s+)?jetzt|momentan|im moment|derzeit|in diesem moment|aktuelle?|ge?rade|so früh wie möglich|frühestmöglich|neulich|vorher|zur ?zeit|im augenblick)\b

Thank you.