search

microsoft / Recognizers-Text

Microsoft.Recognizers.Text provides recognition and resolution of numbers, units, date/time, etc. in multiple languages (ZH, EN, FR, ES, PT, DE, IT, TR, HI, NL. Partial support for JA, KO, AR, SV). Packages available at: https://www.nuget.org/profiles/Recognizers.Text, https://www.npmjs.com/~recognizers.text
MIT License
1.68k stars 430 forks source link

Fix Recognizers cannot recognize next next week/weekend in Chinese #3147

Closed MichaelMWW closed 3 months ago

MichaelMWW commented 3 months ago

Fix Recognizers cannot recognize 下下周(next next week), 下下周末(next next weekend) in Chinese.

tellarin commented 3 months ago

@MichaelMWW Have you signed the CLA? The auto check says it's still pending too. Thanks.

MichaelMWW commented 3 months ago

@microsoft-github-policy-service agree company="Microsoft"

@MichaelMWW please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

MichaelMWW commented 3 months ago

@microsoft-github-policy-service agree company="Microsoft"

MichaelMWW commented 3 months ago

This looks reasonable. But to make sure all works correctly, you also need to add specs at the Model level in DateTimeModel.json Thanks for the comments. I notice that in DateTimeModel.json, there are also some other specs lacking, like 下周(next week), do all test specs need to add specs in Model level? Anyway, I have already added new test specs this time to DateTimeModel.json. BTW, do you know if similar cases happen in Japanese or Korean? The bug is just for Chinese. I have done some research, in Japanese or Korean, they both have similar saying which we may handle in the future.

MichaelMWW commented 3 months ago

@MichaelMWW Have you signed the CLA? The auto check says it's still pending too. Thanks. Finished now.